Skip to content

Commit e0f112e

Browse files
HazATclaude
andcommitted
ci(lighthouse): move upload script into root scripts/ folder
Address review feedback from @mydea: a 70-line upload script does not warrant its own workspace package. - Move `dev-packages/lighthouse-bundle/bundle-and-upload.mjs` to `scripts/lighthouse-bundle-and-upload.mjs` alongside the other repo utilities (`bump-size-limits.mjs`, `ci-print-build-artifact-paths.mjs`, etc.). - Drop the now-empty `dev-packages/lighthouse-bundle/` package and its entry in the root `workspaces` list. - Update the nightly workflow to invoke the new path. - Strip a stale `~/Projects/...` reference and an internal scratchpad pointer from the script's JSDoc header while we are in the file. Co-Authored-By: claude-sonnet-4-5 <noreply@anthropic.com>
1 parent 6015961 commit e0f112e

4 files changed

Lines changed: 2 additions & 18 deletions

File tree

.github/workflows/lighthouse.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,4 +30,4 @@ jobs:
3030
- run: yarn build:tarball
3131
- run: yarn test:prepare
3232
working-directory: dev-packages/e2e-tests
33-
- run: node dev-packages/lighthouse-bundle/bundle-and-upload.mjs
33+
- run: node scripts/lighthouse-bundle-and-upload.mjs

dev-packages/lighthouse-bundle/package.json

Lines changed: 0 additions & 12 deletions
This file was deleted.

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,7 @@
109109
"dev-packages/clear-cache-gh-action",
110110
"dev-packages/external-contributor-gh-action",
111111
"dev-packages/rollup-utils",
112-
"dev-packages/bundler-tests",
113-
"dev-packages/lighthouse-bundle"
112+
"dev-packages/bundler-tests"
114113
],
115114
"devDependencies": {
116115
"@rollup/plugin-commonjs": "^25.0.7",

dev-packages/lighthouse-bundle/bundle-and-upload.mjs renamed to scripts/lighthouse-bundle-and-upload.mjs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@
66
* the upload succeeds.
77
*
88
* Single-app static matrix: 1 app × 3 modes = 3 cells.
9-
* See plan scratchpad #182 for design details.
10-
*
11-
* Wire protocol: ~/Projects/sentry-lhci/docs/sentry-javascript-handoff.md
129
*
1310
* Zero runtime dependencies — uses Node 22 builtins (fetch, FormData, Blob) and
1411
* the system `tar`. Every external command is invoked via `execFileSync` with

0 commit comments

Comments
 (0)