fix(profiler): scope require to binding import call#13834
Closed
JonasBa wants to merge 18 commits into
Closed
Conversation
3 tasks
AbhiPrasad
reviewed
Oct 2, 2024
Contributor
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
This needs a regression test
JonasBa
force-pushed
the
jb/profiling/requrie
branch
from
42e2a5b to
a92ae7e
Compare
Member
Author
I'm going to do some testing first to see if this is even true, opened it thinking we have tests for isCJS and it would fail or pass, but doesn't look like we do. |
Contributor
size-limit report 📦
|
AbhiPrasad
approved these changes
Oct 4, 2024
JonasBa
force-pushed
the
jb/profiling/requrie
branch
from
b80980e to
2a49051
Compare
Member
Author
|
This breaks bundlers 😭 |
This reverts commit bdfb055.
Member
|
@JonasBa is this still relevant or should we close this? |
Member
Author
|
Not relevant anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dont override global require, as it causes issues with our esm/cjs runtime detection and instead scope it to binding import call
Fixes: #13662