feat(core): Add Supabase Queues support #15921
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
onurtemizkan
force-pushed
the
onur/supabase-queues
branch
from
bbadd60 to
e7b3370
Compare
onurtemizkan
force-pushed
the
onur/supabase-integration
branch
from
1bc2897 to
d387514
Compare
onurtemizkan
force-pushed
the
onur/supabase-queues
branch
from
e7b3370 to
56a2d84
Compare
onurtemizkan
force-pushed
the
onur/supabase-queues
branch
from
56a2d84 to
13d60e0
Compare
onurtemizkan
force-pushed
the
onur/supabase-integration
branch
4 times, most recently
from
423397d to
556703c
Compare
onurtemizkan
force-pushed
the
onur/supabase-queues
branch
from
13d60e0 to
74869e4
Compare
onurtemizkan
force-pushed
the
onur/supabase-queues
branch
from
e63915a to
719c8b6
Compare
lforst
reviewed
May 8, 2025
| }, | ||
| }, | ||
| async span => { | ||
| return (Reflect.apply(target, thisArg, argumentsList) as Promise<unknown>).then((res: unknown) => { |
There was a problem hiding this comment.
We should probably also end the span when it throws/rejects? We can also set the status of the span then.
| name: 'supabase.db.rpc', | ||
| attributes: { | ||
| [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.db.supabase', | ||
| [SEMANTIC_ATTRIBUTE_SENTRY_OP]: op, |
There was a problem hiding this comment.
I think we can add the messaging.system attribute to be 'supabase' as described in https://develop.sentry.dev/sdk/telemetry/traces/modules/queues/
Comment on lines
+238
to
+239
| const isProducerSpan = argumentsList[0] === 'enqueue'; | ||
| const isConsumerSpan = argumentsList[0] === 'dequeue'; |
There was a problem hiding this comment.
I don't know if this recently changed, but here they show send and pop as rpc args: https://supabase.com/docs/guides/queues/quickstart#enqueueing-and-dequeueing-messages 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #14611
Can't E2E test this at the moment, because the local Supabase instance needs to be configured after each reset via UI.