fix(remix): Remove vendored types #16218
Merged
+40
−298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurtemizkan
force-pushed
the
onur/remix-vendor-types-v2
branch
from
a5a3b0e to
aeec315
Compare
onurtemizkan
changed the title
onurtemizkan
commented
May 8, 2025
| error != null && | ||
| typeof error.status === 'number' && | ||
| typeof error.statusText === 'string' && | ||
| typeof error.internal === 'boolean' && |
There was a problem hiding this comment.
Looks like error.internal does not exist in the latest types
There was a problem hiding this comment.
should we keep it around for backwards compatibility?
There was a problem hiding this comment.
Turns out this function is already exported. So I removed it and isDeferredData to use the peerDependency.
7ef5353
onurtemizkan
force-pushed
the
onur/remix-vendor-types-v2
branch
from
aeec315 to
fea71ce
Compare
AbhiPrasad
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #15615
Removed the vendored types and started importing them from Remix v2 packages. Also added
@remix-run/server-runtimeasdevDependencyandpeerDependency