feat(node): Add maxRequestBodySize
#16225
Conversation
s1gr1d
force-pushed
the
sig/maxRequestBodySize
branch
from
560976f to
7a21af7
Compare
size-limit report 📦
|
| * | ||
| * @default 'medium' | ||
| */ | ||
| maxRequestBodySize?: 'none' | 'small' | 'medium' | 'always'; |
There was a problem hiding this comment.
should we rename this to maxIncomingRequestBodySize? It is not clear right now that this only applies to incoming requests, not outgoing ones 😅
There was a problem hiding this comment.
I got the name from the general Sentry docs: https://develop.sentry.dev/sdk/expected-features/#attaching-request-body-in-server-sdks
To be uniform with other SDKs, it would be beneficial to keep the name, but I agree that it would be clearer with incoming. At least, the information is available in the JSDoc 😅
There was a problem hiding this comment.
we don't need to have the same name, if we think something else is better :) maybe you could also check with other sdk folks, if this also applies to outgoing requests in other implementations or just to incoming?
| function patchRequestToCaptureBody( | ||
| req: http.IncomingMessage, | ||
| isolationScope: Scope, | ||
| maxRequestBodySize: 'none' | 'small' | 'medium' | 'always', |
There was a problem hiding this comment.
l: We could actually type this to omit none as allowed value, and then avoid the further check in here, as we actually guard agains this already before calling this?
| try { | ||
| // eslint-disable-next-line @typescript-eslint/unbound-method | ||
| req.on = new Proxy(req.on, { | ||
| apply: (target, thisArg, args: Parameters<typeof req.on>) => { | ||
| const [event, listener, ...restArgs] = args; | ||
|
|
||
| if (event === 'data') { | ||
| DEBUG_BUILD && logger.log(INSTRUMENTATION_NAME, 'Handling request.on("data")'); | ||
| if (DEBUG_BUILD) { | ||
| logger.log(INSTRUMENTATION_NAME, 'Handling request.on("data")'); |
There was a problem hiding this comment.
l: Let's combine these into a single log line, e.g. Handling request.on("data") with maximum request body size ...
Adds
maxRequestBodySizeto the NodehttpIntegration.The setting controls the maximum size of HTTP request bodies attached to events.
Available options:
closes #16179