ref(bun): Ensure bun is latest for local tests #16244
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| res.on('end', () => { | ||
| // Execute the downloaded script | ||
| exec(scriptData, installError => { |
Check failure
Code scanning / CodeQL
Uncontrolled command line Critical
| }); | ||
| }) | ||
| .on('error', e => { | ||
| console.error('Failed to download the installation script:', e); |
Check warning
Code scanning / CodeQL
Log injection Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 1 day ago
To fix the issue, we need to sanitize the error message contained in the e object before logging it. Specifically:
- Extract the error message from the
eobject usinge.message. - Remove any newline (
\n) or carriage return (\r) characters from the message usingString.prototype.replace. - Log the sanitized message instead of the raw
eobject.
This ensures that any potentially malicious input in the error message is neutralized before being written to the log.
Suggested changeset
1
packages/bun/scripts/install-bun.js
| @@ -63,3 +63,4 @@ | ||
| .on('error', e => { | ||
| console.error('Failed to download the installation script:', e); | ||
| const sanitizedMessage = e.message.replace(/\n|\r/g, ""); | ||
| console.error('Failed to download the installation script:', sanitizedMessage); | ||
| process.exit(1); |
Copilot is powered by AI and may make mistakes. Always verify output.
AbhiPrasad
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that my bun version locally was old, leading to weird test issues.
Now, our install script will ensure this is the latest version. On CI, we already test against the latest version.
(Noticed this because bun 1.0.2 which I had installed reports itself as Node 18.5.0 which lead to ESM warnings)