You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@AbhiPrasad Does this mean we will by default send the user's name, email, and ID? Or does it just mean that developers can use the setUser functionality without sendDefaultPII set to true?
If the SDK automatically collects user information (and thus calls Sentry.setUser for a user), we should gate this behind sendDefaultPii.
If a user explicitly calls Sentry.setUser, thats not default PII, that's the user opting in explicitly to the behaviour, so we should attach user information to all outgoing events as appropriate.
In this change we just remove sendDefaultPii gating user scope info (from Sentry.setUser) being applied to logs. We do not change behaviour about setting user automatically for users. Essentially we assume if the user info is already on the scope, the user wants to also see it in their events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref getsentry/sentry-docs#13974