ref(flags): rewrite span flag tracking to not use global map #16651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliu39
requested review from
chargome,
a team and
AbhiPrasad
and removed request for
a team
|
@chargome I'm curious if the team has concerns on performance? If a customer is repeatedly evaluating 100s of flags and calling |
AbhiPrasad
reviewed
Jun 18, 2025
There was a problem hiding this comment.
We previously did have some issues with spanToJSON - but the performance should be much better now.
Might be nice to benchmark - you can probably test server-side with profiling a node app: https://nodejs.org/en/learn/getting-started/profiling
|
Talked with @AbhiPrasad , closing for now until I get more bandwidth to play with benchmarking experiments. The map implementation should be fine for releasing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #16485 (review)
Instead of tracking the evaluated feature flags in a global weakmap, we can directly check the span attributes by converting to JSON.