Skip to content

feat(core): MCP server instrumentation without breaking Miniflare #16817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 28 commits into
base: develop
Choose a base branch
from
Draft

feat(core): MCP server instrumentation without breaking Miniflare #16817

wants to merge 28 commits into from
+1,808 −460

Conversation

betegon
Copy link
Member

@betegon betegon commented Jul 4, 2025 •
edited
Loading

Closes #16826

Different approach from #16807 .

Using Proxy was causing issues in cloudflare #16182.

Now using fill we shouldn't have those problems as fill doesn't create a new wrapper object with a different identity, so now:

  1. fill just replaces the method on the existing object
  2. The transport object keeps its original identity
  3. When transport.start() runs and accesses private fields, this is still the original transport object
  4. The WeakMap recognizes it as the same object that owns the private fields

betegon added 24 commits June 27, 2025 20:46
@betegon
feat(mcp-server): Enhance transport handling and request instrumentation
dff2080
@betegon
test transport layer
cb28ccc
@betegon
refactor(mcp-server.test): Simplify test setup by using beforeEach fo…
1480b78 
…r mock instances
@betegon
test(mcp-server): Add tests for span creation and semantic convention…
5a97d69 
…s in MCP server
@betegon
test(mcp-server): Update tests to control transport connection in ind…
03077f8 
…ividual cases
@betegon
test(mcp-server): Refine span attributes and transport details
cac9bd0
@betegon
test(mcp-server): Replace direct tracing module calls with spies for …
37ef9a9 
…improved test isolation
@betegon
feat(mcp-server): Add TypeScript type definitions for MCP server inst…
ac015ce 
…rumentation
@betegon
feat(mcp-server): Introduce MCP attributes and methods for enhanced t…
c2f3e82 
…racing and monitoring
@betegon
test(mcp-server): Add tests for span creation with various notificati…
094574f 
…on types
@betegon
test(mcp-server): Update test to use spy for startSpan
9972b09
@betegon
refactor(mcp-server): improve span handling and attribute extraction
ef52da5
@betegon
simplify attributes
aee709b
@betegon
refactor(mcp-server): improve types
edc4e3c
@betegon
refactor(mcp-server): refactor span handling and utility functions fo…
62ca0f3 
…r MCP server instrumentation
@betegon
remove unused import and comment legacy support
08c39f1
@betegon
refactor(mcp-server): improve notification span handling and set attr…
fe2c865 
…ibute names to match OTEL draft semantic convention
@betegon
refactor(mcp-server): span and attribute creation
ec3cb6f
@betegon
refactor(mcp-server): method configuration and argument extraction fo…
e193118 
…r improved instrumentation
@betegon
refactor(mcp-server): improve transport type handling and add tests f…
347422c 
…or stdio and SSE transports
@betegon
Merge branch 'develop' into bete/mcp-server-semantic-convention
02cb799
@betegon
fix lint
9776402
@betegon
refactor(mcp-server): use fill for method wrapping for transport hand…
d4c74a9 
…lers
@betegon
Merge branch 'develop' into bete/mcp-server-semantic-convention-fill
25297f6
@betegon betegon self-assigned this Jul 4, 2025
@betegon betegon requested a review from AbhiPrasad July 4, 2025 18:28
@betegon betegon changed the title Bete/mcp server semantic convention fill feat(core): MCP server instrumentation without breaking Miniflare Jul 4, 2025
AbhiPrasad
AbhiPrasad reviewed Jul 7, 2025
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, all good from my eyes in overall direction!

@betegon
Copy link
Member Author

betegon commented Jul 7, 2025

Thanks @AbhiPrasad! Will keep working on this and close the other PR using Proxy. Will apply your suggestions here!

@betegon betegon mentioned this pull request Jul 7, 2025
Closed
2 tasks
betegon added 4 commits July 8, 2025 14:04
@betegon
move files to intregations directory
7b5fd86
@betegon
use parseStringToURLObject for url handling and update test
97990c6
@betegon
(draft) fix span duration
1efda74
@betegon
Add tool call results and MCP spans duration to cover their children …
aa0a9fd 
…duration. adds configuration, extraction, and transport utilities. Introduce span creation functions and improves method wrapping for improved telemetry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@betegon betegon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MCP Server tracing instrumentation
2 participants
@betegon @AbhiPrasad