Skip to content

feat(astro): Deprecate passing runtime config to astro integration #16839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mydea
Copy link
Member

@mydea mydea commented Jul 8, 2025

Closes #16837

This should not break anything, I actually added a test to verify injecting this works as expected. We now simply console.warn when some runtime config is passed in the astro integration. Also, no more type completion exists for these, but they are still accepted via Record<string, unknown>.

@mydea mydea requested review from Lms24 and s1gr1d July 8, 2025 08:22
@mydea mydea self-assigned this Jul 8, 2025
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Sentry Vite Plugin Ignores Astro's `excludeTracing`

The excludePerformanceMonitoring mapping for options.bundleSizeOptimizations?.excludeTracing was prematurely removed from the Sentry Vite plugin configuration. This mapping translated the Astro integration's excludeTracing option to the Vite plugin's excludePerformanceMonitoring option. Its removal, intended for a future Vite plugin version (v2.22.0) not yet guaranteed, causes the excludeTracing option to be ignored, breaking bundle size optimizations for users who rely on it to exclude performance monitoring.

packages/astro/src/integration/index.ts#L104-L108

},
bundleSizeOptimizations: {
...bundleSizeOptimizations,
...unstable_sentryVitePluginOptions?.bundleSizeOptimizations,
},

Fix in CursorFix in Web


Was this report helpful? Give feedback by reacting with 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove non-build related astro integration types
2 participants