Skip to content

feat(vercel-edge): Do not vendor in all OpenTelemetry dependencies #16841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2025

Conversation

mydea
Copy link
Member

@mydea mydea commented Jul 8, 2025

Previously, most of the OTEL dependencies have been devDependencies of the vercel-edge package. This PR fixes this by properly defining the dependencies we have.

NOTE: This was not per se incorrect, just not really necessary - we used to inline all of these dependencies into the vercel-edge SDK.

Only the @opentelemetry/sdk-trace-base dependency remains a devDependency, which means it is bundled in. Without this, edge routes somehow fail on next 13 :/

@mydea mydea self-assigned this Jul 8, 2025
@mydea mydea force-pushed the fn/vercel-edge-deps branch from 7a7a455 to 0c471f9 Compare July 8, 2025 14:38
@mydea mydea marked this pull request as ready for review July 8, 2025 14:38
@mydea mydea requested review from chargome and Lms24 July 8, 2025 14:39
@mydea mydea changed the title feat(vercel-edge): Ensure OpenTelemetry dependencies are correct feat(vercel-edge): Do not vendor in all OpenTelemetry depedencies Jul 8, 2025
@mydea mydea changed the title feat(vercel-edge): Do not vendor in all OpenTelemetry depedencies feat(vercel-edge): Do not vendor in all OpenTelemetry dependencies Jul 8, 2025
@mydea mydea force-pushed the fn/vercel-edge-deps branch from 0c471f9 to f121a5d Compare July 9, 2025 11:01
@mydea mydea enabled auto-merge (squash) July 9, 2025 11:02
@mydea mydea merged commit a5173b7 into develop Jul 9, 2025
51 checks passed
@mydea mydea deleted the fn/vercel-edge-deps branch July 9, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants