feat(node): Add shouldHandleDiagnosticsChannelError option to fastifyIntegration

[onurtemizkan]

Resolves: #16819

This requires the Fastify integration to be manually added while initialising Sentry.

Sentry.init({
  integrations: [
    Sentry.fastifyIntegration({
      shouldHandleError(_error, _request, reply) {
        return reply.statusCode >= 500;
      },
    });
  },
});

Though I think this may be a bit confusing for Fastify v4/v3 setupFastifyErrorHandler users, as this will be a no-op in these cases, maybe we can change the name to shouldHandleDiagnosticsChannelError or something like that? 🤔

[github-actions]

size-limit report 📦

Path	Size	% Change	Change
@sentry/browser	23.99 kB	-	-
@sentry/browser - with treeshaking flags	23.76 kB	-	-
@sentry/browser (incl. Tracing)	39.59 kB	-	-
@sentry/browser (incl. Tracing, Replay)	77.78 kB	-	-
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags	70.86 kB	-	-
@sentry/browser (incl. Tracing, Replay with Canvas)	82.5 kB	-	-
@sentry/browser (incl. Tracing, Replay, Feedback)	94.66 kB	-	-
@sentry/browser (incl. Feedback)	40.75 kB	-	-
@sentry/browser (incl. sendFeedback)	28.7 kB	-	-
@sentry/browser (incl. FeedbackAsync)	33.59 kB	-	-
@sentry/react	25.76 kB	-	-
@sentry/react (incl. Tracing)	41.59 kB	-	-
@sentry/vue	28.37 kB	-	-
@sentry/vue (incl. Tracing)	41.39 kB	-	-
@sentry/svelte	24.01 kB	-	-
CDN Bundle	25.5 kB	-	-
CDN Bundle (incl. Tracing)	39.61 kB	-	-
CDN Bundle (incl. Tracing, Replay)	75.59 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback)	81.06 kB	-	-
CDN Bundle - uncompressed	74.5 kB	-	-
CDN Bundle (incl. Tracing) - uncompressed	117.66 kB	-	-
CDN Bundle (incl. Tracing, Replay) - uncompressed	231.96 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed	244.78 kB	-	-
@sentry/nextjs (client)	43.23 kB	-	-
@sentry/sveltekit (client)	40.05 kB	-	-
@sentry/node	162.06 kB	+0.03%	+33 B 🔺
@sentry/node - without tracing	98.64 kB	-	-
@sentry/aws-serverless	124.4 kB	-	-

View base workflow run

[cursor]

Bug: Race Condition in Error Handling

The test has a race condition. The errorEventPromise.then(() => { test.fail(); }) callback is not awaited, allowing test.fail() to execute asynchronously after the test has completed. This can lead to flaky tests where an incorrectly captured error is not reported. The promise handler should be awaited with a timeout or Promise.race() should be used.

dev-packages/e2e-tests/test-applications/node-fastify-5/tests/errors.test.ts#L36-L39

sentry-javascript/dev-packages/e2e-tests/test-applications/node-fastify-5/tests/errors.test.ts

Lines 36 to 39 in f513f8a

	errorEventPromise.then(() => {
	test.fail();
	});

Fix in Cursor • Fix in Web

---

Was this report helpful? Give feedback by reacting with 👍 or 👎

[AbhiPrasad]

Though I think this may be a bit confusing for Fastify v4/v3 setupFastifyErrorHandler users, as this will be a no-op in these cases, maybe we can change the name to shouldHandleDiagnosticsChannelError or something like that?

Yeah good point. I wouldn't mind changing the name to shouldHandleDiagnosticsChannelError. And then adding a doc string that explicitly says this option only works in Fastify v5