feat(core): Add ignoreSpans option
#17078
Conversation
size-limit report 📦
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@mydea, perfect timing. I was about to try to use beforeSendSpan. Do you have a prerelease with this or plan to merge it soon? |
|
Hey @amccloud thx for expressing interest! I just made some optimizations to this PR. We'll merge this soon. Expect it to be released Update: sorry, but we actually need to wait for next week to merge this. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
@bcoe I think it's easier and more bundle-size efficient to keep the options separate for now. Worth noting though that users can set |
| } | ||
|
|
||
| const nameMatches = pattern.name ? isMatchingPattern(span.description, pattern.name) : true; | ||
| const opMatches = pattern.op ? span.op && isMatchingPattern(span.op, pattern.op) : true; |
There was a problem hiding this comment.
Bug: Span Ignoring Fails for Empty Operations
The shouldIgnoreSpan function fails to correctly evaluate ignoreSpans patterns for spans with an empty op value. The condition span.op && isMatchingPattern(span.op, pattern.op) short-circuits when span.op is an empty string (""), as empty strings are falsy. This prevents isMatchingPattern from being called, causing spans with empty op values to not be ignored even when pattern.op is configured to match them (e.g., /^$/). The check should explicitly distinguish empty strings from undefined (e.g., span.op != null) to ensure proper pattern matching.
Locations (1)
This adds a new
ignoreSpansoption to all SDKs. This can be used as follows:this will drop spans before they are sent. Eventual child spans in the same envelope will be re-parented, if possible.
Closes #16820