Skip to content

ref(aws-serverless): Add type to captured event mechanism #17248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Jul 31, 2025

see #17212
closes #17247

@Lms24 Lms24 marked this pull request as ready for review July 31, 2025 10:06
@Lms24 Lms24 requested review from msonnb and andreiborza July 31, 2025 10:06
@Lms24 Lms24 self-assigned this Jul 31, 2025
@Lms24 Lms24 requested a review from AbhiPrasad August 1, 2025 13:10
@@ -501,7 +501,7 @@ describe('AWSLambda', () => {
// @ts-expect-error just mocking around...
expect(evtProcessor(event).exception.values[0]?.mechanism).toEqual({
handled: false,
type: 'generic',
type: 'auto.function.aws-serverless.handler',
Copy link
Member Author

@Lms24 Lms24 Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adjusted the types to follow trace origin. It's not 100% identical to the span origin because for the span it's auto.function.serverless. However, I think we might wanna adjust that to .aws-serverless as the current one is likely a leftover of @sentry/serverless.

@Lms24 Lms24 requested a review from msonnb August 1, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust mechanism in aws-serverless SDK
2 participants