fix(browser): Improve navigation vs. redirect detection #17275
+310
−84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to improve our
navigation
root vs.navigation.redirect
child span detection logic in the defaultbrowserTracingIntegration
:I was a bit confused about the previous logic of interaction timestamps, including the tests. So in attempt to clear it up, I also renamed and slightly reworked the tests. Also added a couple of new ones, including one that tests a series of redirects and navigations. Chances are though, that I'm missing an important detail why we reused interaction timestamps prior to the last root span.
First part of #17282. From this issue, we should still consider bringing this functionality to all BT integrations but one step at a time :)