feat(core): Accumulate tokens for gen_ai.invoke_agent spans from child LLM calls
#17281
+54
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| // TODO: Determine how to handle token aggregation for tool call spans. | ||
| for (const span of event.spans) { | ||
| accumulateTokensFromChildSpans(span, event.spans); | ||
| } |
There was a problem hiding this comment.
Bug: Token Accumulation Error in Nested Spans
Token accumulation for nested gen_ai.invoke_agent spans is incorrect. The accumulateTokensFromChildSpans function processes spans in arbitrary array order. This means a parent gen_ai.invoke_agent span may aggregate tokens from its children before those children have fully accumulated tokens from their own descendants, resulting in incomplete token totals on the parent.
Locations (1)
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently,
gen_ai.invoke_agentspans (representing operations likegenerateText()) contain inaccurate token usage information. Users can only see token data on individualgen_ai.generate_textchild spans, but the tokens are not accumulated across nested spans, making it difficult to track total token consumption for complete AI operations.Solution
Implement token accumulation for
gen_ai.invoke_agentspans by iterating over client LLM child spans and aggregating their token usage.