ref(core): Improve event mechanism for supabase integration
#17286
+18
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
commented
Aug 1, 2025
| @@ -448,6 +454,7 @@ function instrumentPostgRESTFilterBuilder(PostgRESTFilterBuilder: PostgRESTFilte | |||
| return res; | |||
| }, | |||
| (err: Error) => { | |||
| // TODO: shouldn't we capture this error? | |||
There was a problem hiding this comment.
@onurtemizkan not sure if this is me missing something or if we should call captureException here. Can you take a look?
There was a problem hiding this comment.
Hmm, looks like this comes from the original implementation we ported:
I don't see a reason why we should not capture this, though.
| @@ -236,6 +236,7 @@ function instrumentAuthOperation(operation: AuthOperationFn, isAdmin = false): A | |||
| captureException(res.error, { | |||
| mechanism: { | |||
| handled: false, | |||
| type: 'auto.db.supabase.auth', | |||
There was a problem hiding this comment.
these types are one level more specific than the trace origin on the spans (auto.db.supabase). I think this is fine.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #17250
ref: #17212