feat(deno): instrument node:http on versions that support it#21009
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
isaacs
force-pushed
the
isaacs/deno-node-http-integration
branch
2 times, most recently
from
83977fa to
e65ba1b
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e65ba1b. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
isaacs
force-pushed
the
isaacs/deno-node-http-integration
branch
2 times, most recently
from
5470f02 to
0bf6036
Compare
This adds a default integration for the `node:http` module's diagnostics channels, on Deno versions that support it. Client is enabled in 2.7.13+, Server is instrumented in 2.8.0+. If either is available, the instrumentation is added by default. If neither is available, then the instrumentation no-ops and warns about being pointless. Test verifies that the current Deno version is handled correctly. close: JS-2031 close: #20059
isaacs
force-pushed
the
isaacs/deno-node-http-integration
branch
from
0bf6036 to
ae650f0
Compare
JPeer264
approved these changes
May 20, 2026
Member
JPeer264
left a comment
JPeer264
left a comment
There was a problem hiding this comment.
LGTM. Nice that finally the pieces can be put together
|
|
||
| const INTEGRATION_NAME = 'DenoHttp'; | ||
|
|
||
| export interface DenoHttpIntegrationOptions { |
Member
There was a problem hiding this comment.
super-l: You think it might make sense to also consolidate these types?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a default integration for the
node:httpmodule's diagnostics channels, on Deno versions that support it. Client is enabled in 2.7.13+, Server is instrumented in 2.8.0+. If either is available, the instrumentation is added by default. If neither is available, then the instrumentation no-ops and warns about being pointless.Test verifies that the current Deno version is handled correctly.
close: JS-2031
close: #20059