test(node-core): Fix flaky cron instrumentation test#21092
Merged
Conversation
github-actions
Bot
requested review from
andreiborza and
mydea
and removed request for
a team
JPeer264
approved these changes
May 22, 2026
Member
JPeer264
left a comment
JPeer264
left a comment
There was a problem hiding this comment.
not a big fan of increasing timeouts, but let's see if it works
JPeer264
force-pushed
the
fix/flaky-node-core-cron-test
branch
from
33ed21a to
2a786b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
suites/cron/cron/test.tsinnode-core-integration-testswas still timing out occasionally on CI (issue #20971). The scenario exits the child process after5000ms and the vitest test uses the default timeout, leaving little headroom for two cron ticks (* * * * * *) plus the HTTP envelope round-trips throughwithMockSentryServer().Root cause
The sibling test in
node-integration-testshad the same flake symptom previously (#20652 / #20663) and was already adjusted to a15_000ms process-exit timeout and a30_000ms vitest test timeout. Thenode-core-integration-testsversion still carried the original tight budgets (5000ms / vitest default), so it remained susceptible to the same timing pressure.This change mirrors the working sibling pattern verbatim — no assertions are altered, no coverage is loosened, only the wall-clock budget grows.
Fixes #20971