ref(node): Remove unused @opentelemetry/instrumentation-http dependency

[nicohrubec]

Removes @opentelemetry/instrumentation-http from @sentry/node dependencies. The otel instrumentation was essentially already removed in #20393 and the dependency seems to just be a leftover.

[andreiborza]

No lockfile changes? 🤔

[nicohrubec]

@andreiborza lol I was also Sus about that but yarn install doesn't do anything

[mydea]

it also seems that the check lockfile job is not really working,

No lockfile changes? 🤔

I also noticed this is not really being checked, we have a step for this but this seems to not work properly - opened a PR here to fix this: #21115

[mydea]

@andreiborza lol I was also Sus about that but yarn install doesn't do anything

I think we have another dependency on this, in node-core-integration-tests. do we still need this? I guess we are testing that something interops with this, so likely yes...?

[nicohrubec]

@mydea yes it looks like we still use this for some integration tests that check that users can use the otel instrumentation and nothing breaks so I think that's still useful

[andreiborza]

Ah right, yea for node-core I added some tests for that. I think we can drop those tests tbh, we're walking away from being that interop with otel so no need for that scenario?

[nicohrubec]

there is actually a bunch of tests for interop, both in node and node core integration tests and multiple e2e test apps. I am also fine with removing if we no longer want/need to support this

[nicohrubec]

if we are not supporting interop anymore, do we then still have a need for https://github.com/getsentry/sentry-javascript/blob/develop/packages/node-core/src/types.ts#L12 or can we remove that in v11?

[andreiborza]

if we are not supporting interop anymore, do we then still have a need for develop/packages/node-core/src/types.ts#L12 or can we remove that in v11?

Those are going away too.

[JPeer264]

If this line gets removed then we also get rid of the yarn.lock entry:

sentry-javascript/dev-packages/node-core-integration-tests/package.json

Line 32 in a3ebe47

"@opentelemetry/instrumentation-http": "0.214.0",

Seems like I'm too late to the party, everything got answered :D

[mydea]

I think it's OK to leave these tests and the dependency for now, we can remove this on v11 branch then.

[nicohrubec]

Shouldn't hurt to remove the node dependency already? I'll create follow up tickets for the tests and deprecation

[JPeer264]

I'm ok with this removal.