Repository navigation
fix(server-utils): Nest Flue runs on Node under the request that dispatched them - #25549
Open
RulaKhaled wants to merge 2 commits into
Open
RulaKhaled wants to merge 2 commits into
RulaKhaled wants to merge 2 commits into
Conversation
Collaborator
Author
|
bugbot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit b4f85a5. Configure here.
RulaKhaled
marked this pull request as ready for review
October 20, 2026 12:38
RulaKhaled
requested review from
JPeer264,
isaacs and
mydea
and removed request for
a team
October 20, 2026 12:38
Contributor
…atched them Flue's Node coordinator runs every submission from one long-lived loop that keeps the async context of the first request that started it (withastro/flue#813), so every later agent run landed in that request's trace. Record the active span and isolation scope on `submission_queued`, which Flue emits inside the admitting call, and restore them when the run starts. Cloudflare is left as it is. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ean scopes A submission admitted by another process, replayed by idempotency key or evicted from the map has no record to restore, so its run kept the context the claim loop inherited from an unrelated request, and lost its `traceparent`. Run it in clean scopes with a new trace instead, through the existing `withCleanScopes` helper, which also gives restored runs a clean current scope. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
RulaKhaled
force-pushed
the
fix/flue-node-agent-trace
branch
from
October 26, 2026 18:32
b4f85a5 to
590eff7
Compare
Contributor
size-limit report 📦Compared: 78d0c90 (PR test merge using develop at ad71ef6) Against: ad71ef6 (develop) · base run #63604 ✅ Baseline matches: this diff contains only this PR's changes.
|
Contributor
Optional E2E testsSome optional checks were not successful. They do not block the merge. 2 not successful, 58 successful. See the run.
Successful checks
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Node, every Flue agent run after the first landed in the trace of the first request that dispatched one, and later requests' traces had no agent spans. Flue's Node coordinator runs all submissions from one long-lived loop that keeps the first request's async context (withastro/flue#813).
Flue emits
submission_queuedinside the admitting call, so the integration now records the active span and isolation scope there and restores them when the run starts. Cloudflare is unchanged, since each turn there already starts from its own Durable Object alarm. This relies on Flue's current coordinator, which Flue plans to replace withpi-durable, so it needs another look then.Found by the Node send-to-sentry e2e app for Flue (#24753, PR #25550).
🤖 Generated with Claude Code