Allow passing arbitrary event types to the rate limiter#1831
Merged
Conversation
cleptric
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to re-use the rate limiter in: getsentry/sentry-php-agent#16
Since we already store arbitrary rate-limits anyway it makes sense we can also check for them instead of only the ones we have defined in our event type enum.
With PHP's type juggling this might not be a breaking change unlessNevermind, we can remove any breaking concern by just doing what I've done in now 👍strict_typesis defined. Unsure if we can make this change.