chore(ci): Fixes iOS binary size diff failure #4784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 28, 2025
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6e4d2e1+dirty | 1231.82 ms | 1240.18 ms | 8.36 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6e4d2e1+dirty | 2.63 MiB | 3.77 MiB | 1.14 MiB |
Previous results on branch: antonis/ci-ios-binary-size
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a202c7a+dirty | 1229.63 ms | 1230.33 ms | 0.71 ms |
| 1a94d77+dirty | 1219.10 ms | 1217.38 ms | -1.72 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a202c7a+dirty | 2.63 MiB | 3.69 MiB | 1.05 MiB |
| 1a94d77+dirty | 2.63 MiB | 3.69 MiB | 1.06 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6e4d2e1+dirty | 394.19 ms | 378.08 ms | -16.11 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6e4d2e1+dirty | 7.15 MiB | 8.40 MiB | 1.25 MiB |
Previous results on branch: antonis/ci-ios-binary-size
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a202c7a+dirty | 398.12 ms | 447.65 ms | 49.53 ms |
| 1a94d77+dirty | 469.30 ms | 614.86 ms | 145.56 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a202c7a+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| 1a94d77+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
antonis
requested review from
krystofwoldrich and
lucas-zimerman
as code owners
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6e4d2e1+dirty | 1226.76 ms | 1233.13 ms | 6.37 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6e4d2e1+dirty | 3.19 MiB | 4.33 MiB | 1.15 MiB |
Previous results on branch: antonis/ci-ios-binary-size
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a202c7a+dirty | 1218.98 ms | 1215.89 ms | -3.09 ms |
| 1a94d77+dirty | 1222.51 ms | 1230.16 ms | 7.65 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a202c7a+dirty | 3.19 MiB | 4.25 MiB | 1.07 MiB |
| 1a94d77+dirty | 3.19 MiB | 4.25 MiB | 1.07 MiB |
Android (legacy) Performance metrics 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Increase iOS binary size diff by 100KB (to 1300 KB) to avoid failing binary size checks.
💡 Motivation and Context
I've noticed that
metrics (new, ios)check has started to fail consistently (though marginally) due to small changes in the size of the app in the Feedback Widget Drop 2 branch.Notes:
💚 How did you test it?
CI
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog