Skip to content

Conversation

antonis
Copy link
Contributor

@antonis antonis commented Aug 27, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

Based on #5105

📜 Description

Changelog

8.20.0

Fixes

  • Do not use named capturing groups for regular expressions (#4652)
    • This fixes a crash on Android versions below 8.0 (API level 26)

Features

  • Add onDiscard to enable users to track the type and amount of data discarded before reaching Sentry (#4612)
    • Stub for setting the callback on Sentry.init:
      Sentry.init(options -> {
        ...
        options.setOnDiscard(
         (reason, category, number) -> {
           // Your logic to process discarded data
         });
      });

8.19.1

Fixes

  • Do not store No-Op scopes onto OpenTelemetry Context when wrapping (#4631)
    • In 8.18.0 and 8.19.0 the SDK could break when initialized too late.

💡 Motivation and Context

#4471

💚 How did you test it?

CI, Manual

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

github-actions bot commented Aug 27, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 460.80 ms 478.98 ms 18.18 ms
Size 17.75 MiB 19.64 MiB 1.90 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
10ec2e1 435.28 ms 431.58 ms -3.70 ms
472960b 418.84 ms 405.38 ms -13.46 ms
11cc947 501.96 ms 486.04 ms -15.92 ms
0e27665 356.27 ms 367.74 ms 11.47 ms
7eff2d7 420.64 ms 401.86 ms -18.78 ms
fb47c4a 435.33 ms 434.94 ms -0.40 ms
f870f2d 444.67 ms 449.62 ms 4.95 ms
26515b5 446.24 ms 441.91 ms -4.33 ms
20d0171 366.62 ms 366.43 ms -0.19 ms
c26618b 435.76 ms 430.14 ms -5.62 ms

App size

Revision Plain With Sentry Diff
10ec2e1 17.75 MiB 19.60 MiB 1.85 MiB
472960b 17.75 MiB 19.58 MiB 1.83 MiB
11cc947 17.75 MiB 19.60 MiB 1.86 MiB
0e27665 17.75 MiB 19.60 MiB 1.85 MiB
7eff2d7 17.75 MiB 19.60 MiB 1.85 MiB
fb47c4a 17.75 MiB 19.60 MiB 1.85 MiB
f870f2d 17.75 MiB 19.58 MiB 1.83 MiB
26515b5 17.75 MiB 19.60 MiB 1.86 MiB
20d0171 17.75 MiB 19.60 MiB 1.85 MiB
c26618b 17.75 MiB 19.60 MiB 1.85 MiB

Previous results on branch: antonis/bump_to_android_sdk_8.20.0

Startup times

Revision Plain With Sentry Diff
633d8c4 491.67 ms 477.14 ms -14.52 ms

App size

Revision Plain With Sentry Diff
633d8c4 17.75 MiB 19.64 MiB 1.90 MiB

Copy link
Contributor

github-actions bot commented Aug 27, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 383.47 ms 444.07 ms 60.60 ms
Size 7.15 MiB 8.37 MiB 1.22 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
0e27665+dirty 355.91 ms 422.52 ms 66.61 ms
7eff2d7+dirty 393.13 ms 426.77 ms 33.65 ms
f870f2d+dirty 398.49 ms 434.24 ms 35.75 ms
26515b5+dirty 389.83 ms 443.94 ms 54.11 ms
472960b+dirty 394.39 ms 376.18 ms -18.20 ms
11cc947+dirty 385.96 ms 420.08 ms 34.12 ms
20d0171+dirty 380.17 ms 422.57 ms 42.40 ms
c26618b+dirty 354.44 ms 414.73 ms 60.29 ms
10ec2e1+dirty 373.87 ms 443.64 ms 69.78 ms
3c99746+dirty 400.65 ms 399.59 ms -1.06 ms

App size

Revision Plain With Sentry Diff
0e27665+dirty 7.15 MiB 8.35 MiB 1.20 MiB
7eff2d7+dirty 7.15 MiB 8.35 MiB 1.20 MiB
f870f2d+dirty 7.15 MiB 8.34 MiB 1.18 MiB
26515b5+dirty 7.15 MiB 8.36 MiB 1.21 MiB
472960b+dirty 7.15 MiB 8.34 MiB 1.18 MiB
11cc947+dirty 7.15 MiB 8.36 MiB 1.20 MiB
20d0171+dirty 7.15 MiB 8.35 MiB 1.20 MiB
c26618b+dirty 7.15 MiB 8.36 MiB 1.20 MiB
10ec2e1+dirty 7.15 MiB 8.35 MiB 1.20 MiB
3c99746+dirty 7.15 MiB 8.34 MiB 1.18 MiB

Previous results on branch: antonis/bump_to_android_sdk_8.20.0

Startup times

Revision Plain With Sentry Diff
633d8c4+dirty 350.93 ms 383.33 ms 32.39 ms

App size

Revision Plain With Sentry Diff
633d8c4+dirty 7.15 MiB 8.37 MiB 1.22 MiB

Copy link
Contributor

github-actions bot commented Aug 27, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1215.65 ms 1226.10 ms 10.45 ms
Size 2.63 MiB 3.83 MiB 1.19 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
c26618b+dirty 1230.06 ms 1233.30 ms 3.24 ms
0e27665+dirty 1213.52 ms 1237.61 ms 24.09 ms
20d0171+dirty 1214.96 ms 1215.20 ms 0.25 ms
472960b+dirty 1213.96 ms 1222.58 ms 8.62 ms
26515b5+dirty 1240.49 ms 1237.19 ms -3.30 ms
fb47c4a+dirty 1231.00 ms 1231.33 ms 0.33 ms
7eff2d7+dirty 1225.34 ms 1234.53 ms 9.19 ms
11cc947+dirty 1239.65 ms 1239.64 ms -0.01 ms
10ec2e1+dirty 1228.02 ms 1237.54 ms 9.52 ms
3c99746+dirty 1215.12 ms 1222.31 ms 7.18 ms

App size

Revision Plain With Sentry Diff
c26618b+dirty 2.63 MiB 3.82 MiB 1.19 MiB
0e27665+dirty 2.63 MiB 3.80 MiB 1.17 MiB
20d0171+dirty 2.63 MiB 3.80 MiB 1.17 MiB
472960b+dirty 2.63 MiB 3.79 MiB 1.15 MiB
26515b5+dirty 2.63 MiB 3.83 MiB 1.19 MiB
fb47c4a+dirty 2.63 MiB 3.80 MiB 1.17 MiB
7eff2d7+dirty 2.63 MiB 3.79 MiB 1.16 MiB
11cc947+dirty 2.63 MiB 3.82 MiB 1.19 MiB
10ec2e1+dirty 2.63 MiB 3.82 MiB 1.19 MiB
3c99746+dirty 2.63 MiB 3.78 MiB 1.15 MiB

Previous results on branch: antonis/bump_to_android_sdk_8.20.0

Startup times

Revision Plain With Sentry Diff
633d8c4+dirty 1213.10 ms 1217.55 ms 4.45 ms

App size

Revision Plain With Sentry Diff
633d8c4+dirty 2.63 MiB 3.83 MiB 1.19 MiB

Copy link
Contributor

github-actions bot commented Aug 27, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1218.68 ms 1212.50 ms -6.18 ms
Size 3.19 MiB 4.39 MiB 1.20 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
c26618b+dirty 1228.54 ms 1236.52 ms 7.98 ms
0e27665+dirty 1207.12 ms 1220.33 ms 13.20 ms
20d0171+dirty 1214.21 ms 1220.31 ms 6.10 ms
472960b+dirty 1243.67 ms 1233.57 ms -10.11 ms
26515b5+dirty 1216.98 ms 1224.24 ms 7.27 ms
fb47c4a+dirty 1243.40 ms 1245.86 ms 2.46 ms
7eff2d7+dirty 1224.84 ms 1227.94 ms 3.10 ms
11cc947+dirty 1218.92 ms 1234.24 ms 15.33 ms
10ec2e1+dirty 1229.04 ms 1222.28 ms -6.76 ms
3c99746+dirty 1227.65 ms 1228.81 ms 1.16 ms

App size

Revision Plain With Sentry Diff
c26618b+dirty 3.19 MiB 4.39 MiB 1.20 MiB
0e27665+dirty 3.19 MiB 4.37 MiB 1.18 MiB
20d0171+dirty 3.19 MiB 4.37 MiB 1.18 MiB
472960b+dirty 3.19 MiB 4.36 MiB 1.17 MiB
26515b5+dirty 3.19 MiB 4.39 MiB 1.20 MiB
fb47c4a+dirty 3.19 MiB 4.37 MiB 1.18 MiB
7eff2d7+dirty 3.19 MiB 4.36 MiB 1.17 MiB
11cc947+dirty 3.19 MiB 4.39 MiB 1.20 MiB
10ec2e1+dirty 3.19 MiB 4.39 MiB 1.20 MiB
3c99746+dirty 3.19 MiB 4.35 MiB 1.16 MiB

Previous results on branch: antonis/bump_to_android_sdk_8.20.0

Startup times

Revision Plain With Sentry Diff
633d8c4+dirty 1225.78 ms 1228.08 ms 2.30 ms

App size

Revision Plain With Sentry Diff
633d8c4+dirty 3.19 MiB 4.39 MiB 1.20 MiB

@antonis antonis marked this pull request as ready for review August 27, 2025 18:34
@antonis antonis requested a review from alwx August 27, 2025 18:35
Base automatically changed from antonis/v7-ci-macos15-workaround to v7 August 28, 2025 09:33
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@antonis antonis merged commit ad7a627 into v7 Aug 28, 2025
54 checks passed
@antonis antonis deleted the antonis/bump_to_android_sdk_8.20.0 branch August 28, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants