Skip to content

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Dec 15, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

This PR merges main(v7) on capture-app-start-errors (#4472) and handles:

  • 410 commits of divergence
  • Many native conflicts (96 files)
  • File renames/refactorings (.mm → .m)
  • 29 commits in the feature branch

💡 Motivation and Context

Bring #4472 up to date with the latest main

💚 How did you test it?

CI, Manual

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

krystofwoldrich and others added 30 commits January 21, 2025 17:22
…ructures (#4445)

* Extract Android SDK Init

* Update tests

* Adds changelog

* Fix lint issues

* Rename RNSentryStart instance for clarity

* Converts RNSentryStart to utility class

* Update CHANGELOG.md

---------

Co-authored-by: Krystof Woldrich <[email protected]>
* Convert json object to writable map

* Make class/methods package-private(default)
- Resolved merge conflicts across iOS, Android, and JavaScript/TypeScript code
- Updated iOS implementation to use RNSentryStart API
- Fixed Android compilation errors for Sentry Android SDK v7 compatibility
- Removed deprecated API calls (setEnableTracing, getPackages, getIntegrations)
- Updated Gradle build scripts and resolved conflict markers
- All builds verified: iOS, Android, and Expo sample apps compile successfully
@antonis antonis added the ready-to-merge Triggers the full CI test suite label Dec 15, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025

Warnings
⚠️

🤖 Replay Stubs Check

No changes detected in replay-stubs.jar

All file contents are identical (verified by SHA-256 hash comparison).

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 37325ad

Removed unused import that was causing CI lint failure
- Removed assertions for packages getter (not available in v7)
- Removed assertion for enableTracing property (removed in v7)
- Added comments explaining the API changes
The method was a no-op after v7 API changes, so removing it entirely
to avoid unused parameter warnings from PMD.
- Removed assertions for enableTracing property (removed in v7)
- Removed assertions for packages getter (not available in v7)
- Added comments explaining the API changes
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 405.13 ms 415.16 ms 10.03 ms
Size 43.75 MiB 48.08 MiB 4.32 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
083f560+dirty 358.21 ms 382.00 ms 23.79 ms
ad27f6e+dirty 471.44 ms 516.23 ms 44.79 ms
f081f58+dirty 443.98 ms 480.26 ms 36.28 ms
d916aa3 425.37 ms 427.02 ms 1.65 ms
294387d+dirty 424.30 ms 465.40 ms 41.10 ms
90afdd3+dirty 375.94 ms 377.52 ms 1.58 ms
e07935d+dirty 448.82 ms 489.10 ms 40.29 ms
9b50d32+dirty 455.51 ms 466.56 ms 11.05 ms
eec00c2+dirty 447.08 ms 469.04 ms 21.96 ms
46bd012 387.09 ms 404.47 ms 17.38 ms

App size

Revision Plain With Sentry Diff
083f560+dirty 17.75 MiB 19.70 MiB 1.96 MiB
ad27f6e+dirty 43.75 MiB 48.07 MiB 4.32 MiB
f081f58+dirty 43.75 MiB 47.99 MiB 4.24 MiB
d916aa3 17.75 MiB 20.15 MiB 2.41 MiB
294387d+dirty 43.75 MiB 48.04 MiB 4.29 MiB
90afdd3+dirty 17.75 MiB 19.70 MiB 1.95 MiB
e07935d+dirty 43.75 MiB 47.99 MiB 4.24 MiB
9b50d32+dirty 43.75 MiB 48.04 MiB 4.29 MiB
eec00c2+dirty 43.75 MiB 48.05 MiB 4.29 MiB
46bd012 17.75 MiB 20.15 MiB 2.41 MiB

Previous results on branch: capture-app-start-errors-v7

Startup times

Revision Plain With Sentry Diff
f26d7a8+dirty 571.36 ms 637.92 ms 66.56 ms
60d1e83+dirty 396.72 ms 390.04 ms -6.68 ms

App size

Revision Plain With Sentry Diff
f26d7a8+dirty 43.75 MiB 48.08 MiB 4.32 MiB
60d1e83+dirty 43.75 MiB 48.08 MiB 4.32 MiB

@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 357.38 ms 375.64 ms 18.26 ms
Size 43.94 MiB 48.90 MiB 4.96 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ad27f6e+dirty 484.67 ms 532.79 ms 48.12 ms
f081f58+dirty 468.47 ms 492.64 ms 24.17 ms
294387d+dirty 359.44 ms 393.40 ms 33.97 ms
c08359e+dirty 406.04 ms 428.87 ms 22.83 ms
e07935d+dirty 380.10 ms 377.48 ms -2.62 ms
9b50d32+dirty 429.59 ms 423.89 ms -5.70 ms
3099014+dirty 344.58 ms 404.21 ms 59.63 ms
eec00c2+dirty 367.00 ms 392.12 ms 25.12 ms
a31630c+dirty 359.89 ms 416.90 ms 57.00 ms
e335046+dirty 375.75 ms 392.85 ms 17.10 ms

App size

Revision Plain With Sentry Diff
ad27f6e+dirty 43.94 MiB 48.90 MiB 4.96 MiB
f081f58+dirty 43.94 MiB 48.82 MiB 4.88 MiB
294387d+dirty 43.94 MiB 48.87 MiB 4.93 MiB
c08359e+dirty 7.15 MiB 8.42 MiB 1.27 MiB
e07935d+dirty 43.94 MiB 48.82 MiB 4.88 MiB
9b50d32+dirty 43.94 MiB 48.87 MiB 4.93 MiB
3099014+dirty 7.15 MiB 8.43 MiB 1.27 MiB
eec00c2+dirty 43.94 MiB 48.87 MiB 4.93 MiB
a31630c+dirty 7.15 MiB 8.41 MiB 1.26 MiB
e335046+dirty 43.94 MiB 48.87 MiB 4.93 MiB

Previous results on branch: capture-app-start-errors-v7

Startup times

Revision Plain With Sentry Diff
f26d7a8+dirty 380.15 ms 407.84 ms 27.68 ms
60d1e83+dirty 406.16 ms 422.83 ms 16.67 ms

App size

Revision Plain With Sentry Diff
f26d7a8+dirty 43.94 MiB 48.90 MiB 4.96 MiB
60d1e83+dirty 43.94 MiB 48.90 MiB 4.96 MiB

The file is in the parent directory, so use ../ prefix to fix the import path
The property is deprecated in v7. Tracing is already disabled by setting
tracesSampleRate and tracesSampler to nil.
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1213.96 ms 1215.34 ms 1.38 ms
Size 3.44 MiB 4.67 MiB 1.23 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
000da7a+dirty 1214.31 ms 1221.91 ms 7.61 ms
d1bfbde+dirty 1216.83 ms 1212.83 ms -3.99 ms
59f3a84+dirty 1232.56 ms 1238.12 ms 5.56 ms
5691430+dirty 1218.89 ms 1222.22 ms 3.33 ms
c4e097a+dirty 1229.09 ms 1242.61 ms 13.53 ms
652f785+dirty 1219.66 ms 1223.62 ms 3.96 ms
88890fe+dirty 1219.20 ms 1231.00 ms 11.80 ms
f081f58+dirty 1219.10 ms 1217.57 ms -1.53 ms
276d348+dirty 1224.22 ms 1227.38 ms 3.16 ms
ee69ed5+dirty 1206.79 ms 1213.98 ms 7.19 ms

App size

Revision Plain With Sentry Diff
000da7a+dirty 2.63 MiB 3.91 MiB 1.28 MiB
d1bfbde+dirty 3.41 MiB 4.58 MiB 1.17 MiB
59f3a84+dirty 2.63 MiB 3.99 MiB 1.36 MiB
5691430+dirty 3.41 MiB 4.59 MiB 1.18 MiB
c4e097a+dirty 2.63 MiB 3.87 MiB 1.24 MiB
652f785+dirty 3.41 MiB 4.57 MiB 1.16 MiB
88890fe+dirty 2.63 MiB 4.00 MiB 1.37 MiB
f081f58+dirty 3.41 MiB 4.58 MiB 1.17 MiB
276d348+dirty 2.63 MiB 3.98 MiB 1.34 MiB
ee69ed5+dirty 3.41 MiB 4.59 MiB 1.18 MiB

Previous results on branch: capture-app-start-errors-v7

Startup times

Revision Plain With Sentry Diff
60d1e83+dirty 1207.79 ms 1207.35 ms -0.44 ms
f26d7a8+dirty 1209.49 ms 1207.54 ms -1.95 ms

App size

Revision Plain With Sentry Diff
60d1e83+dirty 3.41 MiB 4.67 MiB 1.26 MiB
f26d7a8+dirty 3.44 MiB 4.67 MiB 1.23 MiB

The enableTracing property is deprecated in Sentry Cocoa SDK v7.
Tracing is already verified to be disabled by checking that
tracesSampleRate and tracesSampler are nil.
@github-actions
Copy link
Contributor

github-actions bot commented Dec 15, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1210.16 ms 1213.57 ms 3.40 ms
Size 3.44 MiB 4.67 MiB 1.23 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
000da7a+dirty 1204.50 ms 1218.94 ms 14.44 ms
d1bfbde+dirty 1221.30 ms 1218.70 ms -2.60 ms
59f3a84+dirty 1205.09 ms 1213.31 ms 8.23 ms
5691430+dirty 1191.06 ms 1189.13 ms -1.94 ms
c4e097a+dirty 1231.35 ms 1246.91 ms 15.56 ms
652f785+dirty 1216.42 ms 1212.21 ms -4.21 ms
88890fe+dirty 1219.00 ms 1222.08 ms 3.08 ms
f081f58+dirty 1208.37 ms 1215.56 ms 7.19 ms
276d348+dirty 1222.10 ms 1229.02 ms 6.92 ms
ee69ed5+dirty 1212.78 ms 1214.91 ms 2.13 ms

App size

Revision Plain With Sentry Diff
000da7a+dirty 3.19 MiB 4.48 MiB 1.29 MiB
d1bfbde+dirty 3.41 MiB 4.58 MiB 1.17 MiB
59f3a84+dirty 3.19 MiB 4.56 MiB 1.37 MiB
5691430+dirty 3.41 MiB 4.59 MiB 1.18 MiB
c4e097a+dirty 3.19 MiB 4.44 MiB 1.25 MiB
652f785+dirty 3.41 MiB 4.57 MiB 1.16 MiB
88890fe+dirty 3.19 MiB 4.57 MiB 1.38 MiB
f081f58+dirty 3.41 MiB 4.58 MiB 1.17 MiB
276d348+dirty 3.19 MiB 4.54 MiB 1.36 MiB
ee69ed5+dirty 3.41 MiB 4.59 MiB 1.18 MiB

Previous results on branch: capture-app-start-errors-v7

Startup times

Revision Plain With Sentry Diff
60d1e83+dirty 1201.87 ms 1204.61 ms 2.74 ms
f26d7a8+dirty 1227.33 ms 1220.67 ms -6.66 ms

App size

Revision Plain With Sentry Diff
60d1e83+dirty 3.41 MiB 4.67 MiB 1.26 MiB
f26d7a8+dirty 3.44 MiB 4.67 MiB 1.23 MiB

Copy link
Contributor Author

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failed Detox tests should be fixed by porting #4914

# Conflicts:
#	packages/core/android/libs/replay-stubs.jar
#	samples/react-native/android/app/build.gradle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Triggers the full CI test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants