Skip to content

fix(core): Always re-initialize native SDK from JS in dev builds #5872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antonis merged 1 commit into from
Mar 24, 2026
Merged

fix(core): Always re-initialize native SDK from JS in dev builds #5872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/core/src/js/sdk.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,11 @@ export function init(passedOptions: ReactNativeOptions): void {
initialScope: safeFactory(userOptions.initialScope, { loggerMessage: 'The initialScope threw an error' }),
};

if (!('autoInitializeNativeSdk' in userOptions) && RN_GLOBAL_OBJ.__SENTRY_OPTIONS__) {
// Options file is present, native SDK is expected to be initialized
if (!('autoInitializeNativeSdk' in userOptions) && RN_GLOBAL_OBJ.__SENTRY_OPTIONS__ && !__DEV__) {
// Options file is present in a release build, native SDK is expected to be initialized
// before JS from the native app entry point (e.g. AppDelegate, MainApplication).
// In dev builds, we always re-initialize from JS to set up the native log bridge
// and provide runtime values (devServerUrl, defaultSidecarUrl, etc.).
// eslint-disable-next-line no-console
console.info('[Sentry] Using options file. Native SDK is expected to be initialized before JS, skipping automatic native initialization from JS.');
options.autoInitializeNativeSdk = false;
Expand Down
34 changes: 29 additions & 5 deletions packages/core/test/sdk.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,10 +135,34 @@ describe('Tests the SDK functionality', () => {
expect(usedOptions()?.dsn).toBe('https://key@example.io/code');
});

it('initializing with __SENTRY_OPTIONS__ disabled native auto initialization', () => {
RN_GLOBAL_OBJ.__SENTRY_OPTIONS__ = {};
init({});
expect(usedOptions()?.autoInitializeNativeSdk).toBe(false);
it('does not disable native auto initialization in dev builds even with __SENTRY_OPTIONS__', () => {
// @ts-expect-error __DEV__ is a global
const originalDev = globalThis.__DEV__;
// @ts-expect-error __DEV__ is a global
globalThis.__DEV__ = true;
try {
RN_GLOBAL_OBJ.__SENTRY_OPTIONS__ = {};
init({});
expect(usedOptions()?.autoInitializeNativeSdk).toBe(true);
} finally {
// @ts-expect-error __DEV__ is a global
globalThis.__DEV__ = originalDev;
}
});

it('disables native auto initialization in release builds with __SENTRY_OPTIONS__', () => {
// @ts-expect-error __DEV__ is a global
const originalDev = globalThis.__DEV__;
// @ts-expect-error __DEV__ is a global
globalThis.__DEV__ = false;
try {
RN_GLOBAL_OBJ.__SENTRY_OPTIONS__ = {};
init({});
expect(usedOptions()?.autoInitializeNativeSdk).toBe(false);
} finally {
// @ts-expect-error __DEV__ is a global
globalThis.__DEV__ = originalDev;
}
});

it('initializing without __SENTRY_OPTIONS__ enables native auto initialization', () => {
Expand All @@ -155,7 +179,7 @@ describe('Tests the SDK functionality', () => {
expect(usedOptions()?.autoInitializeNativeSdk).toBe(true);
});

it('initializing with __SENTRY_OPTIONS__ keeps native auto initialization false if set', () => {
it('respects explicit autoInitializeNativeSdk false even with __SENTRY_OPTIONS__', () => {
RN_GLOBAL_OBJ.__SENTRY_OPTIONS__ = {};
init({
autoInitializeNativeSdk: false,
Expand Down
Loading