fix(tracing): Bound TTID/TTFD to prevent inflated transactions#6210
Open
antonis wants to merge 3 commits into
Open
fix(tracing): Bound TTID/TTFD to prevent inflated transactions#6210antonis wants to merge 3 commits into
antonis wants to merge 3 commits into
Conversation
…igation transactions Apply the existing 30s deadline check to TTID spans and transaction timestamp extension, preventing stale fragment re-creation timestamps from inflating navigation transactions to hours or days on Android. Fixes #6208 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
Contributor
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
antonis
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit aadab2b. Configure here.
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
…and fix formatting Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
@sentry review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 456b148. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Apply the existing 30s
TIME_TO_DISPLAY_TIMEOUT_MSdeadline to TTID spans (both automatic and manual) and to the transaction timestamp extension logic. Previously only TTFD had a deadline guard, and even TTFD's guard didn't prevent the transactionevent.timestampfrom being extended.💡 Motivation and Context
Fixes #6208
On Android with
enableTimeToInitialDisplay: true, when aScreenStackFragmentview is destroyed (e.g., navigating away in aStack > Tab > Stackhierarchy) and later recreated (e.g., POP back),RNSentryReactFragmentLifecycleTracer.onFragmentViewCreatedre-registers aFirstDrawDoneListener. The captured draw timestamp can be minutes or days after the navigation span started.processEventthen unconditionally extendedevent.timestampwith this stale TTID, inflating navigation transactions to hours or days.TTFD already had a
deadline_exceededstatus guard, but it wasn't applied to the transaction timestamp extension. TTID had no deadline guard at all. This change applies the same 30s deadline consistently to both TTID and TTFD across all code paths.💚 How did you test it?
Manual, CI Checks
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps