fix(deps): Resolve shell-quote to >=1.8.4 (Dependabot #547)#6286
Open
antonis wants to merge 1 commit into
Open
fix(deps): Resolve shell-quote to >=1.8.4 (Dependabot #547)#6286antonis wants to merge 1 commit into
antonis wants to merge 1 commit into
Conversation
Addresses Dependabot alert #547 (critical severity). shell-quote's quote() did not escape newlines in object .op values, allowing shell command injection. The package is only a transitive dev/test dependency (via react-native CLI, detox, npm-run-all2, etc.) and is not shipped in the published SDK. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Adds a Yarn
resolutionsentry to force all transitiveshell-quoteinstances to>=1.8.4, fixing the critical command injection vulnerability (Dependabot #547).shell-quote'squote()did not escape newlines in object.opvalues, allowing shell command injection. The fix replaces per-character escaping with strict allowlist validation.💡 Motivation and Context
shell-quoteis not a direct dependency — it's pulled in transitively by dev/test tooling (@react-native-community/cli-tools,detox,npm-run-all2,react-devtools-core,launch-editor,@appium/support). None of these ship in the published SDK, so end users are not affected. Resolving it clears the critical Dependabot alert.💚 How did you test it?
yarn why shell-quoteconfirms all instances resolve to1.8.4yarn buildpassesyarn testpasses📝 Checklist
sendDefaultPIIis enabled🔮 Next steps