-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nextjs): check for '[lang]' folder structure when creating example page #605
Conversation
859a8ba
to
f2fe5a9
Compare
Ping @AbhiPrasad |
Thank you for the PR @HaraldNordgren! I put this on my todo to review |
Hi, thanks for the PR but we will likely not go through with it because Is there a specific reason why the page doesn't work for you directly in |
Hi @lforst Are you sure it's not a convention? It's mentioned here as the way to do internationalization: https://nextjs.org/docs/app/building-your-application/routing/internationalization#routing-overview |
The way I read the docs you shared, it is not a convention: https://nextjs.org/docs/app/building-your-application/routing/internationalization#routing-overview:~:text=Changing%20displayed%20content%20based%20on%20the%20user%E2%80%99s%20preferred%20locale%2C%20or%20localization%2C%20is%20not%20something%20specific%20to%20Next.js Next.js has no built-in way to do this. Everything you do with regard to localization is userland code. This question still stands 🤔:
|
It fails like this if I don't move the example page into the
|
Okay, now I understand. Thanks! This we need to solve differently and more generically than this PR. I created an issue to track this: #607 Thanks for helping out! |
Currently, for my project where pages are placed in
src/app/[lang]
, it will place the example page in the wrong place and it has to be manually moved.