Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sourcemaps): remove ci added step #673

Closed
wants to merge 1 commit into from

Conversation

obostjancic
Copy link
Member

No description provided.

Copy link

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- remove ci added step ([#673](https://github.com/getsentry/sentry-wizard/pull/673))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 81dcbcb

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this is still in draft but what's the motivation for removing this?

@obostjancic
Copy link
Member Author

I see this is still in draft but what's the motivation for removing this?

I was taking a look at the numbers here and it seems like a lot of people are dropping out here (I assume that all no value are aborted). Maybe we could change the wording in this step instead of removing it. 🤷‍♂️

@Lms24
Copy link
Member

Lms24 commented Sep 19, 2024

Hmm I think "empty string" means they probably aborted prior to getting there (?) or they took a branch through the wizard where they're not even confronted with this step.

The reason why we added this step here, was to really tell users that this is an essential step to get everything working correctly in CI (if they actually use CI; that they must have confirmed in a prior prompt). If there's no step, the instructions just rush through to the next point (which might even mean the end of the wizard iirc). So our train of thought was to make that step explicit and have users acknowledge that they have to add this token.

fwiw, I took a look at the dashboard: if we're only interested in the sourcemaps wizard here, I think we should filter the transaction on integration: sourcemaps. Still the "empty string" row has a surprisingly large number. The true/false (false in the sense of "I'll do it later") doesn't surprise me too much though

@Lms24
Copy link
Member

Lms24 commented Sep 19, 2024

I think this query should be more accurate, wdyt?
image

@obostjancic
Copy link
Member Author

I think this query should be more accurate, wdyt? image

Ok yes these numbers make a lot more sense. Thanks for the explanation. Closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let users select CI and explain how to set auth token environment variable
2 participants