Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Support variations in projects on E2E tests. #703

Merged
merged 1 commit into from
Nov 7, 2024
Merged

test: Support variations in projects on E2E tests. #703

merged 1 commit into from
Nov 7, 2024

Conversation

onurtemizkan
Copy link
Collaborator

@onurtemizkan onurtemizkan commented Nov 6, 2024 •
edited
Loading

Ref: #695 (review)

  • Adds utilities to create / modify test project files to check the behaviour when certain files exist or not.
  • Applies those utilites on:
    • Remix to check when there's a custom server implementation
    • SvelteKit when hooks files already exist
  • Adds a README for E2E tests.

@onurtemizkan onurtemizkan marked this pull request as ready for review November 6, 2024 15:16
Lms24
Lms24 approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks Onur!

@Lms24 Lms24 merged commit b724bb9 into master Nov 7, 2024
16 checks passed
@Lms24 Lms24 deleted the onur/e2e-tests-variations branch November 7, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onurtemizkan @Lms24