Skip to content

Conversation

seer-by-sentry[bot]
Copy link
Contributor

Fixes SEER-MOBILE-9. The issue was that: API endpoint returns null for githubWriteIntegration, violating client's expectation of a non-optional dictionary structure.

This change initializes the githubWriteIntegration dictionary with ok: None and repos: [] to prevent potential undefined errors when the check_write_access query parameter is not provided. This ensures a consistent structure for the response, even when write access checks are not explicitly requested.

This fix was generated by Seer in Sentry, triggered by [email protected]. 👁️ Run ID: 2098617

Not quite right? Click here to continue debugging with Seer.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov
Copy link

codecov bot commented Oct 22, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
41289 1 41288 249
View the top 1 failed test(s) by shortest run time
tests.sentry.seer.endpoints.test_group_autofix_setup_check.GroupAIAutofixEndpointSuccessTest::test_successful_setup
Stack Traces | 4.77s run time
#x1B[1m#x1B[.../seer/endpoints/test_group_autofix_setup_check.py#x1B[0m:131: in test_successful_setup
    assert response.data == {
#x1B[1m#x1B[31mE   AssertionError: assert {'billing': {...dged': False}} == {'billing': {...dged': False}}#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE     Omitting 3 identical items, use -vv to show#x1B[0m
#x1B[1m#x1B[31mE     Differing items:#x1B[0m
#x1B[1m#x1B[31mE     {'githubWriteIntegration': None} != {'githubWriteIntegration': {'ok': None, 'repos': []}}#x1B[0m
#x1B[1m#x1B[31mE     #x1B[0m
#x1B[1m#x1B[31mE     Full diff:#x1B[0m
#x1B[1m#x1B[31mE       {#x1B[0m
#x1B[1m#x1B[31mE           'billing': {#x1B[0m
#x1B[1m#x1B[31mE               'hasAutofixQuota': True,#x1B[0m
#x1B[1m#x1B[31mE           },#x1B[0m
#x1B[1m#x1B[31mE     -     'githubWriteIntegration': {#x1B[0m
#x1B[1m#x1B[31mE     ?                               ^#x1B[0m
#x1B[1m#x1B[31mE     +     'githubWriteIntegration': None,#x1B[0m
#x1B[1m#x1B[31mE     ?                               ^^^^^#x1B[0m
#x1B[1m#x1B[31mE     -         'ok': None,#x1B[0m
#x1B[1m#x1B[31mE     -         'repos': [],#x1B[0m
#x1B[1m#x1B[31mE     -     },#x1B[0m
#x1B[1m#x1B[31mE           'integration': {#x1B[0m
#x1B[1m#x1B[31mE               'ok': True,#x1B[0m
#x1B[1m#x1B[31mE               'reason': None,#x1B[0m
#x1B[1m#x1B[31mE           },#x1B[0m
#x1B[1m#x1B[31mE           'setupAcknowledgement': {#x1B[0m
#x1B[1m#x1B[31mE               'orgHasAcknowledged': False,#x1B[0m
#x1B[1m#x1B[31mE               'userHasAcknowledged': False,#x1B[0m
#x1B[1m#x1B[31mE           },#x1B[0m
#x1B[1m#x1B[31mE       }#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants