feat(dashboards): register "details" widget as valid widget on the backend #104062
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
edwardgou-sentry
approved these changes
Nov 27, 2025
DominikB2014
deleted the
dominikbuszowiecki/browse-145-register-details-widget-as-supported-on-the-backend
branch
DominikB2014
added a commit
that referenced
this pull request
Nov 27, 2025
1. Adds a detail widget. This widget accepts a query and will render the first example that matches the query based on the type of span it is. <img width="1090" height="859" alt="image" src="https://github.com/user-attachments/assets/fb97bdd2-9c3e-4d6f-a670-23b4d8cc4692" /> - For now, this only applies to spans and i'm just using the existing`fullSpanDescription` component to do this, but we can iterate on this later on. - This is conditionally added as an option in the widget type dropdown if the feature flag is on. - There's still some UI jank to sort out, i figured it's easier to split it up so the PR doesn't get too large. - I still need to register this on the backend, this will allow me to save a widget of type `details` and test it properly (#104062) 2. Adds a `isChartDisplayType` function. I noticed there's a TON of places that checks isChartWidget. Now that we have 3 non-chart displays i just consolidated the logic to one place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents the
"detail" is not a valid choiceerror when trying to save a details widgetcomplements #104059