feat(dashboards): Add wildcard operators to global filters #104070
+177
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
DominikB2014
approved these changes
Nov 27, 2025
Contributor
DominikB2014
left a comment
DominikB2014
left a comment
There was a problem hiding this comment.
lgtm, but some implementation questions!
Comment on lines
353
to
360
| items={operatorOptions.map(option => ({ | ||
| ...option, | ||
| key: option.value, | ||
| label: option.label, | ||
| textValue: option.textValue, | ||
| onClick: () => { | ||
| setStagedOperator(option.value); | ||
| }, |
Contributor
There was a problem hiding this comment.
Related to the above, isn't the memoization of operatorOptions negated because on every rerender we'll be mapping it a new objects (which triggers children to re-render)
Member
Author
There was a problem hiding this comment.
Good point! I fixed the redundant memoization of operatorOptions and tried my best to group memos where possible. They're def effective but were not clean/optimal at first. Pls let me know what you think before I merge 🙏
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
DominikB2014
approved these changes
Nov 27, 2025
Contributor
DominikB2014
left a comment
DominikB2014
left a comment
There was a problem hiding this comment.
Nice update on the memoization
| if (!filterToken) { | ||
| return []; | ||
| } | ||
| const iniitalValue = globalFilter.value |
Contributor
There was a problem hiding this comment.
Suggested change
| const iniitalValue = globalFilter.value | |
| const initialValue = globalFilter.value |
:D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DAIN-1104