Skip to content

[DRAFT] typing: remove fixtures.sudo_testutils from mypy weaklist - #128162

Draft
cursor[bot] wants to merge 1 commit into
masterfrom
cursor/untyped-modules-typing-3825
Draft

cursor[bot] wants to merge 1 commit into
masterfrom
cursor/untyped-modules-typing-3825

Conversation

@cursor

@cursor cursor Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove fixtures.sudo_testutils from the not yet strongly typed mypy weaklist in pyproject.toml
  • add explicit type annotations for BaseTestCase request/user attributes and helper methods in fixtures/sudo_testutils.py
  • keep existing session behavior while making typing explicit by casting the ad-hoc session dict

Testing

  • .venv/bin/mypy --config-file /tmp/mypy-strict.ini /tmp/sudo_testutils_head.py (before change: 8 typing errors)
  • .venv/bin/mypy --config-file /tmp/mypy-strict.ini fixtures/sudo_testutils.py (after change: success)
  • .venv/bin/python tools/mypy_helpers/check_stronglist.py pyproject.toml

cc @armenzg for review.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Open in Web View Automation 

Co-authored-by: Armen Zambrano G. <armenzg@users.noreply.github.com>
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 20, 2026
@getsantry

getsantry Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry Bot added the Stale label Nov 11, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant