Repository navigation
fix(admin): Restore _admin page title and add admin favicon - #128406
Open
sentry-junior[bot] wants to merge 2 commits into
Open
sentry-junior[bot] wants to merge 2 commits into
sentry-junior[bot] wants to merge 2 commits into
Conversation
The DocumentTitleManager added to gsAdmin in #103150 always writes a title on mount, defaulting to "Sentry", which clobbered the "_admin" title set by the admin.html template (added in getsentry#1955 so admin tabs could be told apart from regular Sentry tabs). Let DocumentTitleManager take a defaultTitle and pass "_admin" from gsAdmin. Also give _admin its own purple favicon, swapped in the same way the stories favicon is.
github-actions
Bot
added
the
Scope: Frontend
natemoo-re
reviewed
Oct 21, 2026
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_admin tabs show up as "Sentry" with the regular Sentry icon, so you can't tell them apart from normal app tabs.
The
admin.htmltemplate in getsentry has set<title>_admin</title>since 2018 (getsentry#1955), for exactly this reason. WhenDocumentTitleManagerwas added to gsAdmin in #103150, it began writingdocument.titleon mount. With no page titles registered, it falls back to"Sentry", which overwrote the template's_admin.This change:
defaultTitleprop toDocumentTitleManager(still"Sentry"by default), and gsAdmin passes"_admin". Pages that register a title will now show up asFoo — _admin.favicon-admin.png): the standard glyph on red, so it doesn't look like the prod, dark, dev, or stories icons. gsAdmin swaps it in at render time, the same way the stories favicon is applied.As far as I can tell, _admin never had a different icon. The
getsentry/images/favicon.icothat was removed in getsentry#2625 was just the Sentry glyph from that era.via Junior system actor
event.--
View Junior Session [Sentry]