Repository navigation
feat(sourcemaps): Add has_debug_ids flag to ProjectArtifactBundle - #130421
Open
sentry-junior[bot] wants to merge 1 commit into
Open
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
Contributor
|
This PR has a migration; here is the generated SQL for for --
-- Add field has_debug_ids to projectartifactbundle
--
ALTER TABLE "sentry_projectartifactbundle" ADD COLUMN "has_debug_ids" boolean DEFAULT false NOT NULL; |
vgrozdanic
previously approved these changes
Nov 9, 2026
lcian
previously approved these changes
Nov 9, 2026
wedamija
previously approved these changes
Nov 9, 2026
sentry-junior
Bot
force-pushed
the
feat/artifact-bundle-has-debug-ids-schema
branch
from
November 10, 2026 15:32
a2c190a to
fc533b4
Compare
sentry-junior
Bot
dismissed stale reviews from vgrozdanic, lcian, and wedamija
November 10, 2026 15:33
The stack changed: has_debug_ids moved from ArtifactBundle to ProjectArtifactBundle with a partial index on project_id, and the PRs are rebased on master. Please review again.
lcian
approved these changes
Nov 10, 2026
wedamija
approved these changes
Nov 11, 2026
Adds a column that says whether the linked bundle has any DebugIdArtifactBundle rows, so checking whether a project uploaded any file with a debug ID can read only the project's links instead of the organization's debug-ID rows. The column is on the link and not on the bundle, so that a partial index on project_id can answer the check with one lookup. Nothing writes or reads it yet. Co-Authored-By: Jan Michael Auer <1433023+jan-auer@users.noreply.github.com>
sentry-junior
Bot
force-pushed
the
feat/artifact-bundle-has-debug-ids-schema
branch
from
November 11, 2026 23:13
fc533b4 to
dd66262
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The source map debugger shows if a project uploaded any file with a debug ID. It runs this check when no debug ID of the event matches an upload. The check queries
sentry_debugidartifactbundle. This table has one row for each debug ID in each bundle. When the project has no debug IDs, the query reads all debug-ID rows of the organization.A bundle gets its debug-ID rows only at its first upload. The rows are deleted only together with the bundle. So a boolean gives the same answer.
This PR adds the
has_debug_idscolumn toProjectArtifactBundle, not toArtifactBundle. A later PR adds a partial index onproject_idthat contains only the links with the flag. With this index, the check is one index lookup for each project. A flag onArtifactBundlecannot do this, because that table has no project column.The column is
NOT NULLwith a database default offalse. Postgres adds this column without a table rewrite, so this is a normal deployment migration:Nothing writes or reads the column yet.
Stack:
via @jan-auer.
--
View Session [Sentry]