Repository navigation
Conversation
billyvg
marked this pull request as ready for review
November 11, 2026 23:23
Contributor
Story previewsPreview the stories changed in this PR on the Vercel deployment: Preview deployment: https://sentry-ia6viwz5m.sentry.dev |
The auto-load modal let any amount above $0 through, sent a $0 daily limit when the field was empty (which blocks all Seer usage), and had no way to leave the daily limit unset. The modal now reads the minimum amount and daily limit from the API, disables saving below them with an inline message, and saves an empty daily limit as no limit. The "Due now" charge preview matches the backend, which loads credits at or below the threshold. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
billyvg
force-pushed
the
billyvong/reveng-733-auto-reload-modal-allows-0-daily-limit
branch
from
November 12, 2026 01:07
b59cd85 to
d27a4a6
Compare
The backend loads credits once the balance is at or below the threshold, but the modal and wallet card said "below", so a wallet at exactly the threshold being charged on turn-on looked like a bug. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






Why?
The Seer auto-load modal didn't enforce the agreed limits: a minimum amount of $15, no $0 daily limit, and an unset daily limit meaning no cap. It let any amount above $0 through. Clearing the daily limit sent $0, which blocks all Seer usage, and there was no way to leave the limit unset.
The "Due now" preview also disagreed with the backend at exactly the threshold. The modal showed no charge, but the backend bills a load at or below the threshold. A new wallet starts at exactly the threshold, so turning auto-load on billed without showing "Due now".
How?
The modal reads the minimum amount and daily limit from the auto-load API instead of hardcoding them. It disables saving below either minimum and shows an inline message. An empty daily limit is saved as
null, meaning no limit. The "Due now" preview now uses at-or-below the threshold, which matches when the backend bills the first load. The modal and wallet card now say auto-load triggers "at or below" the threshold rather than "below".This depends on getsentry/getsentry#23167, which returns
minTopUpCredits,minDailySpendCapCentsand a nullabledailySpendCapCents. That change must deploy first.Fixes REVENG-751
Generated with Claude Code