Repository navigation
Conversation
Monitor cleanup was a test automation. Remove it with its result delivery hook, the POST on the workflow runs endpoint that only started it, and the older run helpers in workflows/runs.py that only it called.
github-actions
Bot
added
the
Scope: Backend
…ve-seer-monitor-cleanup
…ve-seer-monitor-cleanup
…ve-seer-monitor-cleanup # Conflicts: # src/sentry/seer/endpoints/organization_seer_workflow_runs.py
…ve-seer-monitor-cleanup
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 106d4ec. Configure here.
| SeerWorkflowRunExecution, | ||
| SeerWorkflowRunExtras, | ||
| SeerWorkflowRunStatus, | ||
| SeerWorkflowStrategy, |
There was a problem hiding this comment.
Unused terminal statuses leftover
Low Severity
TERMINAL_STATUSES is now unused after deliver_workflow_result, finish_workflow_run, and get_workflow_run_status were removed. It is not referenced anywhere else in the repo.
Reviewed by Cursor Bugbot for commit 106d4ec. Configure here.
| finish_workflow_run, | ||
| get_workflow_run_status, | ||
| ) | ||
| from sentry.seer.workflows.schemas import WorkflowResult |
There was a problem hiding this comment.
Decorator landed on helper
Low Severity
@override_settings(SENTRY_SELF_HOSTED=False) was on the deleted WorkflowRunTest class and now wraps the admit helper. SeerWorkflowRunLifecycleTest never used that override, so remaining tests now change settings during admission for no reason.
Reviewed by Cursor Bugbot for commit 106d4ec. Configure here.
…ve-seer-monitor-cleanup
Monitor cleanup was a test automation and is no longer needed. This removes the
seer/monitor_cleanup/package, its result delivery hook, thePOSTon the workflow runs endpoint that only started it (the frontend only uses theGET), and the older run helpers inworkflows/runs.pythat only it called.runs.pyis now justSeerWorkflowRunLifecycle.Stacked on #130846. Left for follow-ups: the
duplicate_monitorsstrategy value, which needs a migration, theorganizations:seer-workflows-monitor-cleanupflag registration, and the frontend label for that strategy.