Skip to content

feat(autofix): Show a single run's early stop in issue activity #130878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NicoHinderling wants to merge 1 commit into
base: master
Choose a base branch
from
+53 −0
Open

feat(autofix): Show a single run's early stop in issue activity #130878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions static/app/types/group.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,6 +673,7 @@ export enum GroupActivityType {
SEER_PR_READY_FOR_REVIEW = 'seer_pr_ready_for_review',
SEER_ITERATION_STARTED = 'seer_iteration_started',
SEER_ITERATION_COMPLETED = 'seer_iteration_completed',
SEER_STOPPED = 'seer_stopped',
PULL_REQUEST_CLOSED = 'pull_request_closed',
PULL_REQUEST_REOPENED = 'pull_request_reopened',
PULL_REQUEST_MERGED = 'pull_request_merged',
Expand All @@ -695,6 +696,7 @@ export const SEER_ACTIVITY_TYPES = new Set<GroupActivityType>([
GroupActivityType.SEER_ITERATION_STARTED,
GroupActivityType.SEER_ITERATION_COMPLETED,
GroupActivityType.SEER_PR_READY_FOR_REVIEW,
GroupActivityType.SEER_STOPPED,
GroupActivityType.TRIGGER_AUTOFIX,
]);

Expand Down Expand Up @@ -1143,6 +1145,15 @@ interface GroupActivitySeerIterationCompleted extends GroupActivityBase {
type: GroupActivityType.SEER_ITERATION_COMPLETED;
}

interface GroupActivitySeerStopped extends GroupActivityBase {
data: {
reason?: string;
run_id?: number;
suggestion?: string;
};
type: GroupActivityType.SEER_STOPPED;
}

interface GroupActivityUnlinkExternalIssue extends GroupActivityBase {
data: {external_issue_key: string; provider: string};
type: GroupActivityType.UNLINK_EXTERNAL_ISSUE;
Expand Down Expand Up @@ -1240,6 +1251,7 @@ export type GroupActivity =
| GroupActivitySeerPrReadyForReview
| GroupActivitySeerIterationStarted
| GroupActivitySeerIterationCompleted
| GroupActivitySeerStopped
| GroupActivityPullRequestClosed
| GroupActivityPullRequestReopened
| GroupActivityPullRequestMerged
Expand Down
11 changes: 11 additions & 0 deletions static/app/views/issueDetails/activitySection/activityLineItem/activityItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,6 +627,17 @@ function getActivityItemContent({
details,
};
}
case GroupActivityType.SEER_STOPPED:
return {
title: t('Seer stopped early'),
details: (
<Fragment>
{activity.data.reason}
{activity.data.suggestion &&
` ${t('Suggestion: %s', activity.data.suggestion)}`}
</Fragment>
),
};
case GroupActivityType.TRIGGER_AUTOFIX:
switch (activity.data.referrer) {
case 'slack':
Expand Down
30 changes: 30 additions & 0 deletions static/app/views/issueDetails/activitySection/index.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2342,6 +2342,36 @@ describe('ActivitySection', () => {
expect(screen.getByText('Autofix triggered from Slack')).toBeInTheDocument();
});

it('renders a Seer early stop', async () => {
const seerGroup = GroupFixture({
id: '1342',
activity: [
{
type: GroupActivityType.SEER_STOPPED,
id: 'seer-stop-1',
dateCreated: '2020-01-01T00:00:00',
data: {
run_id: 123,
reason: 'The API key expired.',
suggestion: 'Rotate the key.',
},
user: null,
},
],
project,
});

render(
<GroupDataContextProvider group={seerGroup} project={seerGroup.project}>
<ActivitySection group={seerGroup} />
</GroupDataContextProvider>
);
expect(await screen.findByText('Seer stopped early')).toBeInTheDocument();
expect(
screen.getByText('The API key expired. Suggestion: Rotate the key.')
).toBeInTheDocument();
});

it('collapses Seer activity pairs across other activity', async () => {
const seerGroup = GroupFixture({
id: '1343',
Expand Down
Loading