Repository navigation
test(nav): Add visual snapshots for the secondary navigation - #130892
Merged
Merged
Conversation
Cover the secondary sidebar header, titled (collapsible) and untitled sections, separators, active links, leading icons and ellipsized labels, in both the legacy and settings-v3 layouts. The settings snapshots catch the regression fixed in #130889, where the collapsible section title and its chevron stacked onto two rows.
github-actions
Bot
added
the
Scope: Frontend
priscilawebdev
marked this pull request as ready for review
November 12, 2026 10:42
priscilawebdev
enabled auto-merge (squash)
November 12, 2026 10:45
![sentry-junior[bot]](https://avatars.githubusercontent.com/in/2960336?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Looks good to me. The settings-legacy snapshot goes through the legacy canCollapse branch of SectionTitle, which is the path #130889 fixed: the default primary-nav context is sidebar and the sections have titles, so that's covered. The v3 variants also cover the other SectionTitle and Separator branches. Using MemoryRouter with the real useLocation is simpler than the jest.mock setup other snapshot files use, and it keeps useSettingsNavigation and the active-link state working. The file passes in the snapshot job, and the new images are registered.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds visual snapshots for the secondary navigation so layout regressions like the one fixed in #130889 (collapsible section title and chevron stacking onto two rows in the settings nav) get caught in CI.