Repository navigation
perf(relay): Avoid N+1 project queries when debouncing config invalidations - #130894
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
loewenheim
approved these changes
Nov 12, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an N+1 query observed during project creation (and any other flow writing multiple
ProjectOptions inside a single transaction).Root Cause
When
TeamProjectsEndpoint.postruns, it callsapply_default_project_settingsinsidetransaction.atomic, which writes ~10-15 default project options on the new project. Each write goes throughProjectOptionManager.reload_cache->schedule_invalidate_project_config(project_id=...), which registers anon_commitcallback.On transaction commit, every callback runs
_schedule_invalidate_project_config. Each callback issuedProject.objects.values_list("organization__id").get(id=project_id)before callingprojectconfig_debounce_cache.invalidation.is_debounced, producing repeated identicalSELECT "sentry_project"."organization_id" FROM "sentry_project" WHERE "sentry_project"."id" = %squeries even though only the very first callback actually scheduled a task.Solution
In
_schedule_invalidate_project_config, checkis_debounced(project_id=project_id)before querying theProjectmodel. If an invalidation for this project is already queued, emit the existingrelay.projectconfig_cache.skippedmetric and return immediately. The first invocation still looks uporganization_idso that organization-level debouncing remains respected.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes SENTRY-5R56
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.