Repository navigation
Conversation
Now that the frontend knows the expo platform, stop suggesting react-native alongside it for Expo repositories.
github-actions
Bot
added
the
Scope: Backend
…expo-supersede-react-native
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the SCM
expodetection rule supersedereact-nativeagain, so Expo repositories are suggested only as Expo instead of Expo plus React Native.#129679 initially shipped this supersession, but frontends that predate Expo drop platforms they don't know. With
react-nativesuperseded, those frontends fell back to the plainjavascriptresult and suggested the browser SDK for Expo apps. #129679 now keepsreact-nativein the results, and this PR removes it once the frontend knowsexpo.Do not merge until #129680 is deployed to production. Merging #129680 is not enough: the backend and frontend deploy independently.
Stacked on #129680, which is stacked on #129679.
Merge order
Merge and deploy these one at a time, waiting for each deploy before merging the next:
expoas a project platform.expo.exposupersedesreact-nativein SCM detection.Merging them together brings back the window where Expo repos get the browser SDK, or where picking Expo fails with "Invalid platform".