Skip to content

fix(taskworker) Fix more pickle parameter usage in send_async_notification #90779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2025

Conversation

markstory
Copy link
Member

AnonymousUser() can be included in the parameter for notifications and needs special cased serialization logic.

Fixes #90763

…ation

AnonymousUser() can be included in the parameter for notifications and
needs special cased serialization logic.

Fixes #90763
@markstory markstory requested review from a team as code owners May 1, 2025 20:54
@markstory markstory requested a review from a team May 1, 2025 20:54
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 1, 2025
Copy link

codecov bot commented May 2, 2025

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/notifications/utils/tasks.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #90779       +/-   ##
===========================================
+ Coverage   70.82%   87.79%   +16.97%     
===========================================
  Files       10281    10283        +2     
  Lines      583528   583585       +57     
  Branches    22578    22578               
===========================================
+ Hits       413304   512386    +99082     
+ Misses     169794    70769    -99025     
  Partials      430      430               

Copy link
Member

@evanh evanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@markstory markstory merged commit cae9266 into master May 2, 2025
60 checks passed
@markstory markstory deleted the fix-sendnotification-pickle branch May 2, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove pickle usage from src.sentry.notifications.utils.async_send_notification
2 participants