feat: Track alert misfires on EAP #90794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
shruthilayaj
commented
May 1, 2025
| @@ -196,10 +201,10 @@ def get_mismatch_type(mismatches: dict[int, dict[str, float]]): | |||
| if all_rpc_values_zero: | |||
| return MismatchType.RPC_ALWAYS_ZERO, many_low_conf_buckets, many_low_sample_rate_buckets | |||
|
|
|||
| if snql_always_lower: | |||
| if snql_always_lower and total_buckets - len(mismatches) < 2: | |||
There was a problem hiding this comment.
snql can have an extra bucket (because of how we group by timestamps)
There was a problem hiding this comment.
curious, is snql the query layer we use via snuba?
There was a problem hiding this comment.
@nsdeschenes yes - it stands for Snuba Query Language (docs) it used to be the primary way we (the sentry backend) would query clickhouse via snuba. but with the new RPCs, it's not longer the case (although the platform itself may or may not use SnQL under the hood)
There was a problem hiding this comment.
mmmm i see i see, thank you!
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #90794 +/- ##
==========================================
+ Coverage 87.78% 87.81% +0.03%
==========================================
Files 10274 10282 +8
Lines 582608 583565 +957
Branches 22567 22567
==========================================
+ Hits 511423 512459 +1036
+ Misses 70756 70677 -79
Partials 429 429 |
narsaynorath
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some logic to track false positives and false negatives on alert misfires.