fix(trace): Handle too many errors #95004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wmak
commented
Jul 7, 2025
wmak
commented
- When there's over 10k errors and the id we want isn't in that 10k we aren't rendering it. This biasess the error query so that we'll return the requested eventId when requested print(orderby)
- When there's over 10k errors and the id we want isn't in that 10k we
aren't rendering it. This biasess the error query so that we'll return
the requested eventId when requested
print(orderby)
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #95004 +/- ##
==========================================
+ Coverage 87.82% 87.87% +0.04%
==========================================
Files 10479 10452 -27
Lines 605756 604839 -917
Branches 23671 23530 -141
==========================================
- Hits 532027 531494 -533
+ Misses 73365 72984 -381
+ Partials 364 361 -3 |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
- rename to error_id since this only works for errors
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Abdkhan14
approved these changes
Jul 10, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jul 14, 2025
- When there's over 10k errors and the id we want isn't in that 10k we aren't rendering it. This biasess the error query so that we'll return the requested eventId when requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.