Skip to content

chore(trace ai queries): Parallelize attribute values requests #95013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(trace ai queries): Parallelize attribute values requests #95013

wants to merge 1 commit into from
+47 −115

Conversation

aayush-se
Copy link
Member

@aayush-se aayush-se commented Jul 8, 2025 •
edited
Loading

  • Parallelize attribute values substring requests
  • Ensure calls take no longer than 1 second
  • Remove unused attribute values rpc
  • Replace this logic with batch rpc once available

@aayush-se aayush-se requested review from a team as code owners July 8, 2025 01:04
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 8, 2025
@aayush-se aayush-se requested a review from a team July 8, 2025 04:24
@codecov Codecov
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

Attention: Patch coverage is 64.00000% with 9 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/api/endpoints/seer_rpc.py 64.00% 9 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #95013       +/-   ##
===========================================
+ Coverage   77.80%   87.87%   +10.07%     
===========================================
  Files       10445    10445               
  Lines      604162   604157        -5     
  Branches    23591    23591               
===========================================
+ Hits       470071   530929    +60858     
+ Misses     133730    72867    -60863     
  Partials      361      361

ram-senth
ram-senth reviewed Jul 8, 2025
View reviewed changes
src/sentry/api/endpoints/seer_rpc.py
field_with_substring = future_to_field[future]

try:
result = future.result(timeout=timeout_seconds)
Copy link
Member

@ram-senth ram-senth Jul 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor one - I do not think timeout param is meaningful here when you use as_completed.

Copy link
Member Author

@aayush-se aayush-se Jul 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, I assume this means that the timeout in as_completed takes priority over this one right?

Should I even be using as_completed here then in this case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ram-senth ram-senth ram-senth left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aayush-se @ram-senth