-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
ref(replays): Remove dead code and reorganize ingest-replay-recordings consumer #95030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cmanallen
wants to merge
13
commits into
master
Choose a base branch
from
cmanallen/replays-cleanup-ingest-consumer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+968
−613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #95030 +/- ##
==========================================
+ Coverage 86.70% 87.88% +1.18%
==========================================
Files 10444 10447 +3
Lines 604125 604262 +137
Branches 23586 23586
==========================================
+ Hits 523793 531064 +7271
+ Misses 79971 72837 -7134
Partials 361 361 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem statement:
There was a variety of code paths which were no longer used. These were dropped. Additionally some of the code was not well factored. Too many concerns were put into one module and which reduced its ability to integrate with multiple systems and also led to weird control flow for cross module communication. This has been refactored and unit test and integration test coverage has been added.