Skip to content

ref(replays): Remove dead code and reorganize ingest-replay-recordings consumer #95030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

cmanallen
Copy link
Member

Problem statement:

There was a variety of code paths which were no longer used. These were dropped. Additionally some of the code was not well factored. Too many concerns were put into one module and which reduced its ability to integrate with multiple systems and also led to weird control flow for cross module communication. This has been refactored and unit test and integration test coverage has been added.

@cmanallen cmanallen requested a review from a team as a code owner July 8, 2025 13:29
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 8, 2025
cursor[bot]

This comment was marked as outdated.

Copy link

codecov bot commented Jul 8, 2025

Codecov Report

Attention: Patch coverage is 98.51632% with 5 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/replays/usecases/ingest/__init__.py 94.73% 3 Missing ⚠️
src/sentry/replays/consumers/recording.py 96.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #95030      +/-   ##
==========================================
+ Coverage   86.70%   87.88%   +1.18%     
==========================================
  Files       10444    10447       +3     
  Lines      604125   604262     +137     
  Branches    23586    23586              
==========================================
+ Hits       523793   531064    +7271     
+ Misses      79971    72837    -7134     
  Partials      361      361              

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant