Skip to content

feat(trace-eap-waterfall): Updating eap span row children count #97256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2025
Merged

feat(trace-eap-waterfall): Updating eap span row children count #97256

merged 1 commit into from
Aug 6, 2025

Conversation

Abdkhan14
Copy link
Contributor

@Abdkhan14 Abdkhan14 commented Aug 6, 2025 •
edited
Loading

  • When an eap txn is collapsed we still display embedded transactions
  • This PR makes expand buttons always display the count of children upon expand, on eap txn rows. This prevents the number from changing as we toggle the expand state.

Collapsed:
Screenshot 2025-08-06 at 10 55 05 AM

Expanded:
Screenshot 2025-08-06 at 10 55 12 AM

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Aug 6, 2025
@Abdkhan14 Abdkhan14 changed the title feat(trace-eap-waterfall): Updating children span row children count feat(trace-eap-waterfall): Updating eap span row children count Aug 6, 2025
@Abdkhan14 Abdkhan14 marked this pull request as ready for review August 6, 2025 14:56
@Abdkhan14 Abdkhan14 requested a review from a team as a code owner August 6, 2025 14:56
@Abdkhan14 Abdkhan14 merged commit 563f461 into master Aug 6, 2025
49 checks passed
@Abdkhan14 Abdkhan14 deleted the abdk/trace-children-counts branch August 6, 2025 16:34
andrewshie-sentry pushed a commit that referenced this pull request Aug 7, 2025
@Abdkhan14 @andrewshie-sentry
feat(trace-eap-waterfall): Updating eap span row children count (#97256)
6c7b6f6 
- When an eap txn is collapsed we still display embedded transactions
- This PR makes expand buttons always display the count of children upon
expand, on eap txn rows. This prevents the number from changing as we
toggle the expand state.

Collapsed:
<img width="443" height="181" alt="Screenshot 2025-08-06 at 10 55 05 AM"
src="https://github.com/user-attachments/assets/8ed737e4-2df8-4f1b-a80d-4f7ccdc25a07"
/>

Expanded:
<img width="488" height="269" alt="Screenshot 2025-08-06 at 10 55 12 AM"
src="https://github.com/user-attachments/assets/32fd5f1e-1b3e-42b8-baa8-459f9eb96963"
/>

Co-authored-by: Abdullah Khan <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@DominikB2014 DominikB2014 DominikB2014 approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abdkhan14 @DominikB2014