Skip to content

fix(iterate-pr): Stop waiting on review gates#149

Merged
dcramer merged 5 commits into
mainfrom
fix/iterate-pr-review-gates
May 19, 2026
Merged

fix(iterate-pr): Stop waiting on review gates#149
dcramer merged 5 commits into
mainfrom
fix/iterate-pr-review-gates

Conversation

@dcramer
Copy link
Copy Markdown
Member

@dcramer dcramer commented May 19, 2026

Make iterate-pr stop treating draft/no-checks states and human review gates as pending CI. The skill now reports those non-actionable states explicitly while continuing to poll and fix actionable CI failures and high/medium review feedback.

Check Monitoring

fetch_pr_checks.py now includes draft/review metadata and separates actionable pending checks from human gates. monitor_pr_checks.py emits explicit stop markers for no-checks, draft no-checks, and review-gate-only states.

Runtime Guidance

Compress the runtime skill docs into tables and checklists, and add SPEC.md to keep the scope focused on CI iteration rather than merge readiness.

Treat draft PRs with no checks and human approval or review gates as non-actionable stop states instead of pending CI. Tighten the runtime skill prose into tables and add a SPEC maintenance contract for the behavior.

Co-Authored-By: OpenAI Codex <codex@openai.com>
@dcramer dcramer marked this pull request as ready for review May 19, 2026 18:44
Comment thread skills/iterate-pr/scripts/fetch_pr_checks.py
Comment thread skills/iterate-pr/scripts/monitor_pr_checks.py
Report actionable pending checks before failed checks so fetch_pr_checks matches the documented workflow and monitor behavior.

Co-Authored-By: OpenAI Codex <codex@openai.com>
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 657e35a. Configure here.

Comment thread skills/iterate-pr/SKILL.md Outdated
Comment thread skills/iterate-pr/scripts/fetch_pr_checks.py
Comment thread skills/iterate-pr/scripts/fetch_pr_checks.py
Route post-CI high and medium feedback back to the fix step and make the no-checks fetch output explicit for non-draft PRs.

Co-Authored-By: OpenAI Codex <codex@openai.com>
Comment thread skills/iterate-pr/scripts/monitor_pr_checks.py
Allow the monitor to treat gh pr checks exit code 16 as a no-checks response so the no-checks timeout path can run.

Co-Authored-By: OpenAI Codex <codex@openai.com>
Comment thread skills/iterate-pr/scripts/monitor_pr_checks.py
Let monitor_pr_checks opt into an empty list when gh pr checks succeeds with allowed empty output so the no-checks timeout can run.

Co-Authored-By: OpenAI Codex <codex@openai.com>
@dcramer dcramer merged commit 32fdf36 into main May 19, 2026
14 checks passed
@dcramer dcramer deleted the fix/iterate-pr-review-gates branch May 19, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant